Changeset 152229 in webkit

Timestamp:

Jul 1, 2013 9:47:45 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[Curl] WebDownload init method is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=118241

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.

The WebDownload::init() method called when a normal load is changed to a download
because of a decision by the policy delegate, is not implemented for Curl.

• WebDownloadCurl.cpp:

(WebDownload::init): Implement init() method.

Location:

trunk/Source/WebKit/win

Files:

• ChangeLog (modified) (1 diff)
• WebDownloadCurl.cpp (modified) (1 diff)

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2013-07-01  peavo@outlook.com  <peavo@outlook.com>
+
+        [Curl] WebDownload init method is not implemented.
+        https://bugs.webkit.org/show_bug.cgi?id=118241
+
+        Reviewed by Brent Fulgham.
+
+        The WebDownload::init() method called when a normal load is changed to a download
+        because of a decision by the policy delegate, is not implemented for Curl.
+
+        * WebDownloadCurl.cpp:
+        (WebDownload::init): Implement init() method.
+
 2013-07-01  Kangil Han  <kangil.han@samsung.com>
 

trunk/Source/WebKit/win/WebDownloadCurl.cpp

@@ -58 +58 @@
 void WebDownload::init(ResourceHandle* handle, const ResourceRequest& request, const ResourceResponse& response, IWebDownloadDelegate* delegate)
 {
-   notImplemented();
+    if (!handle)
+        return;
+
+    // Stop previous request
+    handle->setDefersLoading(true);
+
+    m_request.adoptRef(WebMutableURLRequest::createInstance(request));
+
+    m_delegate = delegate;
+
+    KURL url(ParsedURLString, request.url());
+
+    m_download.init(this, url);
+
+    start();
 }