Changeset 152314 in webkit


Ignore:
Timestamp:
Jul 2, 2013 12:47:53 PM (11 years ago)
Author:
mhahnenberg@apple.com
Message:

Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
https://bugs.webkit.org/show_bug.cgi?id=118316

Reviewed by Geoffrey Garen.

This is causing some crashiness in release builds. We should replace it with an ASSERT
until we track down all the places that need fixing in bug 118315.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r152300 r152314  
     12013-07-02  Mark Hahnenberg  <mhahnenberg@apple.com>
     2
     3        Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
     4        https://bugs.webkit.org/show_bug.cgi?id=118316
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        This is causing some crashiness in release builds. We should replace it with an ASSERT
     9        until we track down all the places that need fixing in bug 118315.
     10
     11        * bytecode/CodeBlock.h:
     12        (JSC::CodeBlock::bytecodeOffsetForCallAtIndex):
     13
    1142013-07-02  Brent Fulgham  <bfulgham@apple.com>
    215
  • trunk/Source/JavaScriptCore/bytecode/CodeBlock.h

    r150566 r152314  
    224224        if (!callIndices.size())
    225225            return 1;
    226         RELEASE_ASSERT(index < m_rareData->m_callReturnIndexVector.size());
     226        // FIXME: Fix places in DFG that call out to C that don't set the CodeOrigin. https://bugs.webkit.org/show_bug.cgi?id=118315
     227        ASSERT(index < m_rareData->m_callReturnIndexVector.size());
     228        if (index >= m_rareData->m_callReturnIndexVector.size())
     229            return 1;
    227230        return m_rareData->m_callReturnIndexVector[index].bytecodeOffset;
    228231    }
Note: See TracChangeset for help on using the changeset viewer.