Changeset 152340 in webkit

Timestamp:

Jul 2, 2013 10:54:31 PM (11 years ago)

Author:

zandobersek@gmail.com

Message:

[WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure
​https://bugs.webkit.org/show_bug.cgi?id=118280

Reviewed by Darin Adler.

Invalidate the FontCache before disabling and purging the MemoryCache in WebProcess::didClose
and WebProcess::terminate. This frees up additional references to objects that were held
by the FontCache, reducing the amount of 'LEAK: *' output when exiting MiniBrowser or
WebKitTestRunner in debug builds.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebProcess.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-07-02  Zan Dobersek  <zdobersek@igalia.com>
+
+        [WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure
+        https://bugs.webkit.org/show_bug.cgi?id=118280
+
+        Reviewed by Darin Adler.
+
+        Invalidate the FontCache before disabling and purging the MemoryCache in WebProcess::didClose
+        and WebProcess::terminate. This frees up additional references to objects that were held
+        by the FontCache, reducing the amount of 'LEAK: *' output when exiting MiniBrowser or
+        WebKitTestRunner in debug builds.
+
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::terminate):
+        (WebKit::WebProcess::didClose):
+
 2013-07-02  Jessie Berlin  <jberlin@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebProcess.cpp

@@ -617 +617 @@
 #ifndef NDEBUG
     gcController().garbageCollectNow();
+    fontCache()->invalidate();
     memoryCache()->setDisabled(true);
 #endif
@@ -669 +670 @@
 
     gcController().garbageCollectSoon();
+    fontCache()->invalidate();
     memoryCache()->setDisabled(true);
 #endif