Changeset 152354 in webkit

Timestamp:

Jul 3, 2013 7:52:03 AM (11 years ago)

Author:

sergio@webkit.org

Message:

[WK2][GTK] Invalid ASSERTs in WebResources loading code
​https://bugs.webkit.org/show_bug.cgi?id=118352

Reviewed by Carlos Garcia Campos.

The WebKitWebView keeps track of the resources being loaded in a
map. A couple of ASSERTs verify that every loaded resource is
stored in that map.

The map that is cleared each time a new load starts so there is a
small chance that we get notifications for resources that
correspond to previous page loads
(and thus are not stored in the map). We should remove the ASSERT
which is not valid anymore.

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewGetLoadingWebResource):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitWebView.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-07-03  Sergio Villar Senin  <svillar@igalia.com>
+
+        [WK2][GTK] Invalid ASSERTs in WebResources loading code
+        https://bugs.webkit.org/show_bug.cgi?id=118352
+
+        Reviewed by Carlos Garcia Campos.
+
+        The WebKitWebView keeps track of the resources being loaded in a
+        map. A couple of ASSERTs verify that every loaded resource is
+        stored in that map.
+
+        The map that is cleared each time a new load starts so there is a
+        small chance that we get notifications for resources that
+        correspond to previous page loads
+        (and thus are not stored in the map). We should remove the ASSERT
+        which is not valid anymore.
+
+        * UIProcess/API/gtk/WebKitWebView.cpp:
+        (webkitWebViewGetLoadingWebResource):
+
 2013-07-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp

@@ -1623 +1623 @@
 {
     GRefPtr<WebKitWebResource> resource = webView->priv->loadingResourcesMap.get(resourceIdentifier);
-    ASSERT(resource.get());
     return resource.get();
 }