Changeset 152371 in webkit

Timestamp:

Jul 3, 2013 11:50:24 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[ATK] Leak: more leaks in AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=118362

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-03
Reviewed by Christophe Dumez.

Free the memory created by g_strdup_printf.

• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::language):

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::language):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (modified) (1 diff)
• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-07-03  Brian Holt  <brian.holt@samsung.com>
+
+        [ATK] Leak: more leaks in AccessibilityUIElement
+        https://bugs.webkit.org/show_bug.cgi?id=118362
+
+        Reviewed by Christophe Dumez.
+
+        Free the memory created by g_strdup_printf.
+
+        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+        (AccessibilityUIElement::language):
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+        (WTR::AccessibilityUIElement::language):
+
 2013-07-03  Jer Noble  <jer.noble@apple.com>
 

trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp

@@ -437 +437 @@
         return JSStringCreateWithCharacters(0, 0);
 
-    return JSStringCreateWithUTF8CString(g_strdup_printf("AXLanguage: %s", locale));
+    GOwnPtr<char> axValue(g_strdup_printf("AXLanguage: %s", locale));
+    return JSStringCreateWithUTF8CString(axValue.get());
 }
 

trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

@@ -623 +623 @@
         return JSStringCreateWithCharacters(0, 0);
 
-    return JSStringCreateWithUTF8CString(g_strdup_printf("AXLanguage: %s", locale));
+    GOwnPtr<char> axValue(g_strdup_printf("AXLanguage: %s", locale));
+    return JSStringCreateWithUTF8CString(axValue.get());
 }