Changeset 152424 in webkit

Timestamp:

Jul 5, 2013 2:28:23 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

iframe constrained by max-width in full screen
​https://bugs.webkit.org/show_bug.cgi?id=118250

Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-05
Reviewed by Antti Koivisto.

Ensure that contents inside iframe can go full screen properly.

Set max-width and max-height values to the default 'none', so that iframes are not
constrained when entering full screen.

Source/WebCore:

Test: fullscreen/full-screen-iframe-with-max-width-height.html

• css/fullscreen.css:

(iframe:-webkit-full-screen):

LayoutTests:

• fullscreen/full-screen-iframe-with-max-width-height-expected.txt: Added.
• fullscreen/full-screen-iframe-with-max-width-height.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fullscreen/full-screen-iframe-with-max-width-height-expected.txt (added)
• LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/fullscreen.css (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-07-05  Zalan Bujtas  <zalan@apple.com>
+
+        iframe constrained by max-width in full screen
+        https://bugs.webkit.org/show_bug.cgi?id=118250
+
+        Reviewed by Antti Koivisto.
+
+        Ensure that contents inside iframe can go full screen properly.
+
+        Set max-width and max-height values to the default 'none', so that iframes are not
+        constrained when entering full screen.
+
+        * fullscreen/full-screen-iframe-with-max-width-height-expected.txt: Added.
+        * fullscreen/full-screen-iframe-with-max-width-height.html: Added.
+
 2013-07-05  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-07-05  Zalan Bujtas  <zalan@apple.com>
+
+        iframe constrained by max-width in full screen
+        https://bugs.webkit.org/show_bug.cgi?id=118250
+
+        Reviewed by Antti Koivisto.
+
+        Ensure that contents inside iframe can go full screen properly.
+
+        Set max-width and max-height values to the default 'none', so that iframes are not
+        constrained when entering full screen.
+
+        Test: fullscreen/full-screen-iframe-with-max-width-height.html
+
+        * css/fullscreen.css:
+        (iframe:-webkit-full-screen):
+
 2013-07-05  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/css/fullscreen.css

@@ -52 +52 @@
     left: 0 !important;
     top: 0 !important;
+    max-width: none !important;
+    max-height: none !important;
 }