Changeset 152435 in webkit

Timestamp:

Jul 6, 2013 12:24:42 AM (11 years ago)

Author:

Christophe Dumez

Message:

Stop hardcoding interfaces that have indexed getters returning strings
​https://bugs.webkit.org/show_bug.cgi?id=118414

Reviewed by Kentaro Hara.

Stop hardcoding the names of interfaces that have indexed getters returning
strings in the bindings generator. Now that we use the latest Web IDL indexed
getter, more information is provided in the IDL files and the generator is
able to figure out if the indexed getter is returning a DOMString on its own.

No new tests, no behavior change.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorJS.pm (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-07-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
+
+        Stop hardcoding interfaces that have indexed getters returning strings
+        https://bugs.webkit.org/show_bug.cgi?id=118414
+
+        Reviewed by Kentaro Hara.
+
+        Stop hardcoding the names of interfaces that have indexed getters returning
+        strings in the bindings generator. Now that we use the latest Web IDL indexed
+        getter, more information is provided in the IDL files and the generator is
+        able to figure out if the indexed getter is returning a DOMString on its own.
+
+        No new tests, no behavior change.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateGetOwnPropertySlotBody):
+        (GenerateImplementation):
+
 2013-07-05  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -179 +179 @@
 }
 
-sub IndexGetterReturnsStrings
-{
-    my $type = shift;
-
-    return 1 if $type eq "CSSStyleDeclaration" or $type eq "MediaList" or $type eq "DOMStringList" or $type eq "DOMTokenList" or $type eq "DOMSettableTokenList";
-    return 0;
-}
-
 sub AddIncludesForTypeInImpl
 {
@@ -391 +383 @@
         # If the item function returns a string then we let the TreatReturnedNullStringAs handle the cases
         # where the index is out of range.
-        if (IndexGetterReturnsStrings($interfaceName)) {
+        if ($indexedGetterFunction->signature->type eq "DOMString") {
             push(@getOwnPropertySlotImpl, "    if (index != PropertyName::NotAnIndex) {\n");
         } else {
@@ -1980 +1972 @@
 
             if ($indexedGetterFunction) {
-                if (IndexGetterReturnsStrings($interfaceName)) {
+                if ($indexedGetterFunction->signature->type eq "DOMString") {
                     push(@implContent, "    if (index <= MAX_ARRAY_INDEX) {\n");
                 } else {
@@ -2658 +2650 @@
         push(@implContent, "    ${className}* thisObj = jsCast<$className*>(asObject(slotBase));\n");
         push(@implContent, "    ASSERT_GC_OBJECT_INHERITS(thisObj, &s_info);\n");
-        if (IndexGetterReturnsStrings($interfaceName)) {
+        if ($indexedGetterFunction->signature->type eq "DOMString") {
             $implIncludes{"KURL.h"} = 1;
             push(@implContent, "    return jsStringOrUndefined(exec, thisObj->impl()->item(index));\n");