Changeset 152444 in webkit

Timestamp:

Jul 8, 2013 2:00:34 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Leak: GFile* leaking in beginDragWithFilesCallback
​https://bugs.webkit.org/show_bug.cgi?id=118412

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-08
Reviewed by Martin Robinson.

An adoptRef is required to balance ref and deref calls.

• DumpRenderTree/gtk/EventSender.cpp:

(beginDragWithFilesCallback):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/gtk/EventSender.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-07-08  Brian Holt  <brian.holt@samsung.com>
+
+        [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
+        https://bugs.webkit.org/show_bug.cgi?id=118412
+
+        Reviewed by Martin Robinson.
+
+        An adoptRef is required to balance ref and deref calls.
+
+        * DumpRenderTree/gtk/EventSender.cpp:
+        (beginDragWithFilesCallback):
+
 2013-07-06  Sergio Correia  <sergio.correia@openbossa.org>
 

trunk/Tools/DumpRenderTree/gtk/EventSender.cpp

@@ -542 +542 @@
     if (g_str_equal(scheme.get(), "http") || g_str_equal(scheme.get(), "https")) {
         GOwnPtr<gchar> currentDirectory(g_get_current_dir());
-        parentDirectory = g_file_new_for_path(currentDirectory.get());
+        parentDirectory = adoptGRef(g_file_new_for_path(currentDirectory.get()));
     }