Changeset 152527 in webkit

Timestamp:

Jul 10, 2013 12:41:42 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Change recently ratified extensions prefixes from WEBKIT_WEBGL_ to WEBGL_
​https://bugs.webkit.org/show_bug.cgi?id=117786

Patch by Karol Świniarski <​k.swiniarsk2@samsung.com> on 2013-07-10
Reviewed by Dean Jackson.

According to WebGL's revision 10, extensions should be named: WEBGL_lose_context,
WEBGL_depth_texture, WEBGL_compressed_texture_s3tc.

No new tests. Covered by existing tests:
LayoutTests/webgl/conformance/extensions/get-extension.html
LayoutTests/webgl/conformance/context/context-lost.html
LayoutTests/webgl/conformance/extensions/webgl-depth-texture.html
LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-s3tc.html

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/canvas/WebGLRenderingContext.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-07-10  Karol Świniarski  <k.swiniarsk2@samsung.com>
+
+        Change recently ratified extensions prefixes from WEBKIT_WEBGL_ to WEBGL_
+        https://bugs.webkit.org/show_bug.cgi?id=117786
+
+        Reviewed by Dean Jackson.
+
+        According to WebGL's revision 10, extensions should be named: WEBGL_lose_context,
+        WEBGL_depth_texture, WEBGL_compressed_texture_s3tc.
+
+        No new tests. Covered by existing tests:
+        LayoutTests/webgl/conformance/extensions/get-extension.html
+        LayoutTests/webgl/conformance/context/context-lost.html
+        LayoutTests/webgl/conformance/extensions/webgl-depth-texture.html
+        LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-s3tc.html
+
+        * html/canvas/WebGLRenderingContext.cpp:
+        (WebCore::WebGLRenderingContext::getExtension):
+        (WebCore::WebGLRenderingContext::getSupportedExtensions):
+
 2013-07-09  Byungwoo Lee  <bw80.lee@samsung.com>
 

trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp

@@ -2406 +2406 @@
         return m_oesElementIndexUint.get();
     }
-    if (equalIgnoringCase(name, "WEBGL_lose_context")
-        // FIXME: remove this after a certain grace period.
-        || equalIgnoringCase(name, "WEBKIT_WEBGL_lose_context")
-        // FIXME: Is it safe to remove WEBKIT_lose_context now?
-        || equalIgnoringCase(name, "WEBKIT_lose_context")) {
+    if (equalIgnoringCase(name, "WEBGL_lose_context")) {
         if (!m_webglLoseContext)
             m_webglLoseContext = WebGLLoseContext::create(this);
@@ -2426 +2422 @@
             m_webglCompressedTexturePVRTC = WebGLCompressedTexturePVRTC::create(this);
     }
-    if ((equalIgnoringCase(name, "WEBGL_compressed_texture_s3tc")
-         // FIXME: remove this after a certain grace period.
-         || equalIgnoringCase(name, "WEBKIT_WEBGL_compressed_texture_s3tc"))
+    if (equalIgnoringCase(name, "WEBGL_compressed_texture_s3tc")
         && WebGLCompressedTextureS3TC::supported(this)) {
         if (!m_webglCompressedTextureS3TC)
@@ -2434 +2428 @@
         return m_webglCompressedTextureS3TC.get();
     }
-    if ((equalIgnoringCase(name, "WEBGL_depth_texture")
-        // FIXME: remove this after a certain grace period.
-        || equalIgnoringCase(name, "WEBKIT_WEBGL_depth_texture"))
+    if (equalIgnoringCase(name, "WEBGL_depth_texture")
         && WebGLDepthTexture::supported(graphicsContext3D())) {
         if (!m_webglDepthTexture) {
@@ -2959 +2951 @@
         result.append("WEBKIT_WEBGL_compressed_texture_pvrtc");
     if (WebGLCompressedTextureS3TC::supported(this))
-        result.append("WEBKIT_WEBGL_compressed_texture_s3tc");
+        result.append("WEBGL_compressed_texture_s3tc");
     if (WebGLDepthTexture::supported(graphicsContext3D()))
-        result.append("WEBKIT_WEBGL_depth_texture");
+        result.append("WEBGL_depth_texture");
     if (supportsDrawBuffers())
         result.append("EXT_draw_buffers");