Changeset 152570 in webkit


Ignore:
Timestamp:
Jul 11, 2013 8:17:13 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[Coordinated Graphics] Parameter of commitSceneState should be const
https://bugs.webkit.org/show_bug.cgi?id=118564

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-11
Reviewed by Noam Rosenthal.

Parameter of commitSceneState should be const as there should not be any
modifications to the passed CoordinatedGraphicsState.

Source/WebCore:

  • platform/graphics/texmap/coordinated/CompositingCoordinator.h:

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::commitSceneState):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
Location:
trunk/Source
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r152569 r152570  
     12013-07-11  Jae Hyun Park  <jae.park@company100.net>
     2
     3        [Coordinated Graphics] Parameter of commitSceneState should be const
     4        https://bugs.webkit.org/show_bug.cgi?id=118564
     5
     6        Reviewed by Noam Rosenthal.
     7
     8        Parameter of commitSceneState should be const as there should not be any
     9        modifications to the passed CoordinatedGraphicsState.
     10
     11        * platform/graphics/texmap/coordinated/CompositingCoordinator.h:
     12
    1132013-07-11  Radu Stavila  <stavila@adobe.com>
    214
  • trunk/Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.h

    r152183 r152570  
    6464        virtual void willSyncLayerState(CoordinatedGraphicsLayerState&) = 0;
    6565        virtual void notifyFlushRequired() = 0;
    66         virtual void commitSceneState(CoordinatedGraphicsState&) = 0;
     66        virtual void commitSceneState(const CoordinatedGraphicsState&) = 0;
    6767        virtual void paintLayerContents(const GraphicsLayer*, GraphicsContext&, const IntRect& clipRect) = 0;
    6868    };
  • trunk/Source/WebKit2/ChangeLog

    r152555 r152570  
     12013-07-11  Jae Hyun Park  <jae.park@company100.net>
     2
     3        [Coordinated Graphics] Parameter of commitSceneState should be const
     4        https://bugs.webkit.org/show_bug.cgi?id=118564
     5
     6        Reviewed by Noam Rosenthal.
     7
     8        Parameter of commitSceneState should be const as there should not be any
     9        modifications to the passed CoordinatedGraphicsState.
     10
     11        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
     12        (WebKit::CoordinatedLayerTreeHost::commitSceneState):
     13        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
     14
    1152013-07-10  Mark Rowe  <mrowe@apple.com>
    216
  • trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp

    r152183 r152570  
    361361}
    362362
    363 void CoordinatedLayerTreeHost::commitSceneState(WebCore::CoordinatedGraphicsState& state)
     363void CoordinatedLayerTreeHost::commitSceneState(const WebCore::CoordinatedGraphicsState& state)
    364364{
    365365    m_webPage->send(Messages::CoordinatedLayerTreeHostProxy::CommitCoordinatedGraphicsState(state));
  • trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h

    r152183 r152570  
    107107    virtual void willSyncLayerState(WebCore::CoordinatedGraphicsLayerState&) OVERRIDE;
    108108    virtual void notifyFlushRequired() OVERRIDE { scheduleLayerFlush(); };
    109     virtual void commitSceneState(WebCore::CoordinatedGraphicsState&) OVERRIDE;
     109    virtual void commitSceneState(const WebCore::CoordinatedGraphicsState&) OVERRIDE;
    110110    virtual void paintLayerContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, const WebCore::IntRect& clipRect) OVERRIDE;
    111111
Note: See TracChangeset for help on using the changeset viewer.