Changeset 152639 in webkit

Timestamp:

Jul 15, 2013 9:32:41 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
​https://bugs.webkit.org/show_bug.cgi?id=118592

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-15
Reviewed by Martin Robinson.

Added a suppression for pylint false positives and a unit test.

• Scripts/webkitpy/style/checkers/python.py:

(Pylinter):

• Scripts/webkitpy/style/checkers/python_unittest.py:

(PythonCheckerTest.test_check):
(PythonCheckerTest):
(PythonCheckerTest.test_pylint_false_positives):
(PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):

• Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.

(test_popen):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checkers/python.py (modified) (1 diff)
• Scripts/webkitpy/style/checkers/python_unittest.py (modified) (1 diff)
• Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py (added)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-07-15  Brian Holt  <brian.holt@samsung.com>
+
+        check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
+        https://bugs.webkit.org/show_bug.cgi?id=118592
+
+        Reviewed by Martin Robinson.
+
+        Added a suppression for pylint false positives and a unit test.
+
+        * Scripts/webkitpy/style/checkers/python.py:
+        (Pylinter):
+        * Scripts/webkitpy/style/checkers/python_unittest.py:
+        (PythonCheckerTest.test_check):
+        (PythonCheckerTest):
+        (PythonCheckerTest.test_pylint_false_positives):
+        (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
+        * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
+        (test_popen):
+
 2013-07-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/Tools/Scripts/webkitpy/style/checkers/python.py

@@ -96 +96 @@
         "Instance of 'Popen' has no 'stderr' member",
         "Instance of 'Popen' has no 'wait' member",
+        "Instance of 'Popen' has no 'pid' member",
     ]
 

trunk/Tools/Scripts/webkitpy/style/checkers/python_unittest.py

@@ -62 +62 @@
             (4, "pylint/E0602", 5, "Undefined variable 'error'"),
             ])
+
+    def test_pylint_false_positives(self):
+        """Test that pylint false positives are suppressed."""
+        errors = []
+
+        def _mock_handle_style_error(line_number, category, confidence,
+                                     message):
+            error = (line_number, category, confidence, message)
+            errors.append(error)
+
+        current_dir = os.path.dirname(__file__)
+        file_path = os.path.join(current_dir, "python_unittest_falsepositives.py")
+
+        checker = PythonChecker(file_path, _mock_handle_style_error)
+        checker.check(lines=[])
+
+        self.assertEqual(errors, [])