Changeset 153086 in webkit

Timestamp:

Jul 24, 2013 8:44:51 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

WebVTTParser's identifier buffering can ignore subsequent lines
​https://bugs.webkit.org/show_bug.cgi?id=118483

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-07-24
Reviewed by Eric Carlson.

No new tests since this bug can't be reproduced in layout tests.

• html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::parseBytes): Only buffer the identifier if we haven't read an entire line.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/track/WebVTTParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-07-24  Brendan Long  <b.long@cablelabs.com>
+
+        WebVTTParser's identifier buffering can ignore subsequent lines
+        https://bugs.webkit.org/show_bug.cgi?id=118483
+
+        Reviewed by Eric Carlson.
+
+        No new tests since this bug can't be reproduced in layout tests.
+
+        * html/track/WebVTTParser.cpp:
+        (WebCore::WebVTTParser::parseBytes): Only buffer the identifier if we haven't read an entire line.
+
 2013-07-23  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/html/track/WebVTTParser.cpp

@@ -152 +152 @@
         switch (m_state) {
         case Initial:
-            // Buffer up at least 9 bytes before proceeding with checking for the file identifier.
+            // Buffer up at least 9 bytes or a full line before proceeding with checking for the file identifier.
             m_identifierData.append(data, length);
-            if (m_identifierData.size() < bomLength + fileIdentifierLength)
+            if (position == line.sizeInBytes() && m_identifierData.size() < bomLength + fileIdentifierLength)
                 return;