Changeset 153702 in webkit


Ignore:
Timestamp:
Aug 5, 2013 12:16:00 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Source/WebCore: [CSS Background Blending] Specifying background-image and background-color
with opaque image doesn't trigger blending. The fix consists of adding a
check whether blend mode is set in hasOpaqueImage.

https://bugs.webkit.org/show_bug.cgi?id=119434

Patch by Mihai Tica <mitica@adobe.com> on 2013-08-05
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-separate-layer-declaration.html

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasOpaqueImage):

LayoutTests: [CSS Background Blending] Specifying background-image and background-color with opaque
image doesn't trigger blending. Adding ref test to validate the fix.

https://bugs.webkit.org/show_bug.cgi?id=119434i

Patch by Mihai Tica <mitica@adobe.com> on 2013-08-05
Reviewed by Dirk Schulze.

  • css3/compositing/background-blend-mode-separate-layer-declaration-expected.html: Added.
  • css3/compositing/background-blend-mode-separate-layer-declaration.html: Added.
  • css3/compositing/resources/gray_square.svg: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r153690 r153702  
     12013-08-05  Mihai Tica  <mitica@adobe.com>
     2
     3        [CSS Background Blending] Specifying background-image and background-color with opaque
     4        image doesn't trigger blending. Adding ref test to validate the fix.
     5
     6        https://bugs.webkit.org/show_bug.cgi?id=119434i
     7
     8        Reviewed by Dirk Schulze.
     9
     10        * css3/compositing/background-blend-mode-separate-layer-declaration-expected.html: Added.
     11        * css3/compositing/background-blend-mode-separate-layer-declaration.html: Added.
     12        * css3/compositing/resources/gray_square.svg: Added.
     13
    1142013-08-03  Simon Fraser  <simon.fraser@apple.com>
    215
  • trunk/Source/WebCore/ChangeLog

    r153701 r153702  
     12013-08-05  Mihai Tica  <mitica@adobe.com>
     2
     3        [CSS Background Blending] Specifying background-image and background-color
     4        with opaque image doesn't trigger blending. The fix consists of adding a
     5        check whether blend mode is set in hasOpaqueImage.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=119434
     8
     9        Reviewed by Dirk Schulze.
     10
     11        Test: css3/compositing/background-blend-mode-separate-layer-declaration.html
     12
     13        * rendering/style/FillLayer.cpp:
     14        (WebCore::FillLayer::hasOpaqueImage):
     15
    1162013-08-04  Zalan Bujtas  <zalan@apple.com>
    217
  • trunk/Source/WebCore/rendering/style/FillLayer.cpp

    r151565 r153702  
    352352        return true;
    353353
     354    if (m_blendMode != BlendModeNormal)
     355        return false;
     356
    354357    if (m_composite == CompositeSourceOver)
    355358        return m_image->knownToBeOpaque(renderer);
Note: See TracChangeset for help on using the changeset viewer.