Changeset 153781 in webkit

Timestamp:

Aug 7, 2013 2:11:04 AM (11 years ago)

Author:

mihnea@adobe.com

Message:

[CSSRegions] Wrong auto-height region computation for nested named flows
​https://bugs.webkit.org/show_bug.cgi?id=119517

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/abspos-autoheight-nested-region.html

In the case of an (inner) auto-height region that is absolutely positioned in a named flow that is displayed in an (outer) auto-height region,
when we are doing the layout for the named flow we need to add a "forced region break" also for the case of simplified layout, otherwise
the outer auto-height region will not get the chance to compute its auto-height, ending up with a huge value that was used to initialize
the auto-height computed value before the start of the layout algorithm.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedLayout):

LayoutTests:

• fast/regions/abspos-autoheight-nested-region-expected.txt: Added.
• fast/regions/abspos-autoheight-nested-region.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/regions/abspos-autoheight-nested-region-expected.txt (added)
• LayoutTests/fast/regions/abspos-autoheight-nested-region.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBlock.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-08-07  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        [CSSRegions] Wrong auto-height region computation for nested named flows
+        https://bugs.webkit.org/show_bug.cgi?id=119517
+
+        Reviewed by David Hyatt.
+
+        * fast/regions/abspos-autoheight-nested-region-expected.txt: Added.
+        * fast/regions/abspos-autoheight-nested-region.html: Added.
+
 2013-08-07  Krzysztof Czech  <k.czech@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-08-07  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        [CSSRegions] Wrong auto-height region computation for nested named flows
+        https://bugs.webkit.org/show_bug.cgi?id=119517
+
+        Reviewed by David Hyatt.
+
+        Test: fast/regions/abspos-autoheight-nested-region.html
+
+        In the case of an (inner) auto-height region that is absolutely positioned in a named flow that is displayed in an (outer) auto-height region,
+        when we are doing the layout for the named flow we need to add a "forced region break" also for the case of simplified layout, otherwise
+        the outer auto-height region will not get the chance to compute its auto-height, ending up with a huge value that was used to initialize
+        the auto-height computed value before the start of the layout algorithm.
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::simplifiedLayout):
+
 2013-08-06  Stephanie Lewis  <slewis@apple.com>
 

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -2798 +2798 @@
         simplifiedNormalFlowLayout();
 
+    // Make sure a forced break is applied after the content if we are a flow thread in a simplified layout.
+    // This ensures the size information is correctly computed for the last auto-height region receiving content.
+    if (isRenderFlowThread())
+        toRenderFlowThread(this)->applyBreakAfterContent(clientLogicalBottom());
+
     // Lay out our positioned objects if our positioned child bit is set.
     // Also, if an absolute position element inside a relative positioned container moves, and the absolute element has a fixed position