Changeset 153787 in webkit

Timestamp:

Aug 7, 2013 8:00:42 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Do no check seek offset against internal size on gstreamer source element
​https://bugs.webkit.org/show_bug.cgi?id=116533

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-08-07
Reviewed by Philippe Normand.

The internal size on gstreamer source element may be wrong in case the received size in
didReceiveResponse is not accurate. Lets just try to seek and let it fail if necessary.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcSeekDataCb):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-08-07  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
+
+        Do no check seek offset against internal size on gstreamer source element
+        https://bugs.webkit.org/show_bug.cgi?id=116533
+
+        Reviewed by Philippe Normand.
+
+        The internal size on gstreamer source element may be wrong in case the received size in
+        didReceiveResponse is not accurate. Lets just try to seek and let it fail if necessary.
+
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (webKitWebSrcSeekDataCb):
+
 2013-08-07  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

@@ -748 +748 @@
     if (!priv->seekable)
         return FALSE;
-    if (offset > priv->size)
-        return FALSE;
 
     GST_DEBUG_OBJECT(src, "Doing range-request seek");