Changeset 153937 in webkit


Ignore:
Timestamp:
Aug 12, 2013 3:22:06 AM (11 years ago)
Author:
allan.jensen@digia.com
Message:

Resource leak related to gstreamer and videos
https://bugs.webkit.org/show_bug.cgi?id=109350

Reviewed by Eric Carlson.

Since active DOM object are only stopped once and can not be restarted, we can
unreference the media player there, instead of waiting for garbage collection.

If the r152778 is rolled back, this also breaks a circular reference between
GStreamer and WebKit which prevented garbage collecting from triggering.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::stop):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r153936 r153937  
     12013-08-12  Allan Sandfeld Jensen  <allan.jensen@digia.com>
     2
     3        Resource leak related to gstreamer and videos
     4        https://bugs.webkit.org/show_bug.cgi?id=109350
     5
     6        Reviewed by Eric Carlson.
     7
     8        Since active DOM object are only stopped once and can not be restarted, we can
     9        unreference the media player there, instead of waiting for garbage collection.
     10
     11        If the r152778 is rolled back, this also breaks a circular reference between
     12        GStreamer and WebKit which prevented garbage collecting from triggering.
     13
     14        * html/HTMLMediaElement.cpp:
     15        (WebCore::HTMLMediaElement::stop):
     16
    1172013-08-12  Gabor Rapcsanyi  <rgabor@webkit.org>
    218
  • trunk/Source/WebCore/html/HTMLMediaElement.cpp

    r153927 r153937  
    41794179
    41804180    m_asyncEventQueue->close();
     4181
     4182    // Once an active DOM object has been stopped it can not be restarted, so we can deallocate
     4183    // the media player now. Note that userCancelledLoad will already have cleared the player
     4184    // if the media was not fully loaded. This handles all other cases.
     4185    m_player.clear();
    41814186}
    41824187
Note: See TracChangeset for help on using the changeset viewer.