Changeset 154000 in webkit


Ignore:
Timestamp:
Aug 13, 2013 6:14:39 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[GTK] close the volume slider when the media control panel is hidden
​https://bugs.webkit.org/show_bug.cgi?id=119062

Patch by Danilo Cesar Lemes de Paula <​danilo.cesar@collabora.co.uk> on 2013-08-13
Reviewed by Gustavo Noronha Silva.

It's not obvious how to close the volume slider on webkitGtk.
The volume slider should close if the control panel is hidden.

  • html/shadow/MediaControlsGtk.cpp:

(WebCore::MediaControlsGtk::makeTransparent):

  • html/shadow/MediaControlsGtk.h:
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r153998 r154000  
     12013-08-13  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
     2
     3        [GTK] close the volume slider when the media control panel is hidden
     4        https://bugs.webkit.org/show_bug.cgi?id=119062
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        It's not obvious how to close the volume slider on webkitGtk.
     9        The volume slider should close if the control panel is hidden.
     10
     11        * html/shadow/MediaControlsGtk.cpp:
     12        (WebCore::MediaControlsGtk::makeTransparent):
     13        * html/shadow/MediaControlsGtk.h:
     14
    1152013-08-13  Commit Queue  <commit-queue@webkit.org>
    216

  • trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp

    r148099 r154000  
    202202}
    203203
     204
     205void MediaControlsGtk::makeTransparent()
     206{
     207    MediaControls::makeTransparent();
     208
     209    if (m_volumeSliderContainer)
     210        m_volumeSliderContainer->hide();
     211}
     212
    204213void MediaControlsGtk::showVolumeSlider()
    205214{

  • trunk/Source/WebCore/html/shadow/MediaControlsGtk.h

    r143463 r154000  
    4747    virtual void updateCurrentTimeDisplay() OVERRIDE;
    4848    virtual void showVolumeSlider() OVERRIDE;
     49    virtual void makeTransparent() OVERRIDE;
    4950
    5051#if ENABLE(VIDEO_TRACK)
Note: See TracChangeset for help on using the changeset viewer.