Changeset 154001 in webkit

Timestamp:

Aug 13, 2013 7:44:37 AM (11 years ago)

Author:

rakuco@webkit.org

Message:

[EFL][DRT] Simplify call to reverseFind()
​https://bugs.webkit.org/show_bug.cgi?id=119746

Reviewed by Christophe Dumez.

Follow-up to r153977.

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(pathSuitableForTestResult): Instead of defining a static variable
that's only used in a single place, pass '/' to reverseFind() directly.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/efl/DumpRenderTreeChrome.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-08-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
+
+        [EFL][DRT] Simplify call to reverseFind()
+        https://bugs.webkit.org/show_bug.cgi?id=119746
+
+        Reviewed by Christophe Dumez.
+
+        Follow-up to r153977.
+
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (pathSuitableForTestResult): Instead of defining a static variable
+        that's only used in a single place, pass '/' to reverseFind() directly.
+
 2013-08-13  Alberto Garcia  <berto@igalia.com>
 

trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

@@ -337 +337 @@
 }
 
-static const char divider = '/';
-
 static String pathSuitableForTestResult(const char* uriString)
 {
@@ -354 +352 @@
     String mainFrameUrlPathString = mainFrameURL.path();
     String pathString = uri.path();
-    String basePath = mainFrameUrlPathString.substring(0, mainFrameUrlPathString.reverseFind(divider) + 1);
+    String basePath = mainFrameUrlPathString.substring(0, mainFrameUrlPathString.reverseFind('/') + 1);
 
     if (!basePath.isEmpty() && pathString.startsWith(basePath))