Changeset 154013 in webkit


Ignore:
Timestamp:
Aug 13, 2013 11:07:00 AM (11 years ago)
Author:
robert@webkit.org
Message:

Section's collapsed borders painted in wrong place in rtl tables
​https://bugs.webkit.org/show_bug.cgi?id=119691

Reviewed by Darin Adler.

Source/WebCore:

Table row-groups can be RTL too, so look to the section rather than the
table when deciding the direction of a row. The section will inherit the
table's direction if it doesn't override it.

Test: fast/table/paint-collapsed-borders-rtl-section.html

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::hasStartBorderAdjoiningTable):
(WebCore::RenderTableCell::hasEndBorderAdjoiningTable):

LayoutTests:

  • fast/table/paint-collapsed-borders-rtl-section-expected.html: Added.
  • fast/table/paint-collapsed-borders-rtl-section.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r154012 r154013  
     12013-08-13  Robert Hogan  <robert@webkit.org>
     2
     3        Section's collapsed borders painted in wrong place in rtl tables
     4        https://bugs.webkit.org/show_bug.cgi?id=119691
     5
     6        Reviewed by Darin Adler.
     7
     8        * fast/table/paint-collapsed-borders-rtl-section-expected.html: Added.
     9        * fast/table/paint-collapsed-borders-rtl-section.html: Added.
     10
    1112013-08-13  Christophe Dumez  <ch.dumez@sisa.samsung.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r154012 r154013  
     12013-08-13  Robert Hogan  <robert@webkit.org>
     2
     3        Section's collapsed borders painted in wrong place in rtl tables
     4        https://bugs.webkit.org/show_bug.cgi?id=119691
     5
     6        Reviewed by Darin Adler.
     7
     8        Table row-groups can be RTL too, so look to the section rather than the
     9        table when deciding the direction of a row. The section will inherit the
     10        table's direction if it doesn't override it.
     11
     12        Test: fast/table/paint-collapsed-borders-rtl-section.html
     13
     14        * rendering/RenderTableCell.cpp:
     15        (WebCore::RenderTableCell::hasStartBorderAdjoiningTable):
     16        (WebCore::RenderTableCell::hasEndBorderAdjoiningTable):
     17
    1182013-08-13  Christophe Dumez  <ch.dumez@sisa.samsung.com>
    219

  • trunk/Source/WebCore/rendering/RenderTableCell.cpp

    r153510 r154013  
    485485    bool isStartColumn = !col();
    486486    bool isEndColumn = table()->colToEffCol(col() + colSpan() - 1) == table()->numEffCols() - 1;
    487     bool hasSameDirectionAsTable = hasSameDirectionAs(table());
     487    bool hasSameDirectionAsTable = hasSameDirectionAs(section());
    488488
    489489    // The table direction determines the row direction. In mixed directionality, we cannot guarantee that
    … …  
    496496    bool isStartColumn = !col();
    497497    bool isEndColumn = table()->colToEffCol(col() + colSpan() - 1) == table()->numEffCols() - 1;
    498     bool hasSameDirectionAsTable = hasSameDirectionAs(table());
     498    bool hasSameDirectionAsTable = hasSameDirectionAs(section());
    499499
    500500    // The table direction determines the row direction. In mixed directionality, we cannot guarantee that
Note: See TracChangeset for help on using the changeset viewer.