Changeset 154027 in webkit

Timestamp:

Aug 13, 2013 3:48:43 PM (11 years ago)

Author:

ap@apple.com

Message:

[Mac] fast/dom/attr-style-too-lazy.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=119763

Reviewed by Darin Adler.

• DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
a test, it would just semi-randomly leak to the next one.
(-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
for good measure.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/mac/UIDelegate.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-08-13  Alexey Proskuryakov  <ap@apple.com>
+
+        [Mac] fast/dom/attr-style-too-lazy.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=119763
+
+        Reviewed by Darin Adler.
+
+        * DumpRenderTree/mac/UIDelegate.mm:
+        (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
+        a test, it would just semi-randomly leak to the next one.
+        (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
+        for good measure.
+
 2013-08-13  Tim Horton  <timothy_horton@apple.com>
 

trunk/Tools/DumpRenderTree/mac/UIDelegate.mm

@@ -198 +198 @@
 - (void)webView:(WebView *)sender setStatusText:(NSString *)text
 {
-    if (gTestRunner->dumpStatusCallbacks())
+    if (!done && gTestRunner->dumpStatusCallbacks())
         printf("UI DELEGATE STATUS CALLBACK: setStatusText:%s\n", [text UTF8String]);
 }
@@ -291 +291 @@
 - (BOOL)webView:(WebView *)webView didPressMissingPluginButton:(DOMElement *)element
 {
-    printf("MISSING PLUGIN BUTTON PRESSED\n");
+    if (!done)
+        printf("MISSING PLUGIN BUTTON PRESSED\n");
     return TRUE;
 }