Changeset 154064 in webkit


Ignore:
Timestamp:
Aug 14, 2013 12:14:00 PM (11 years ago)
Author:
rwlbuis@webkit.org
Message:

Assertion failure in RenderObject::drawLineForBoxSide
https://bugs.webkit.org/show_bug.cgi?id=108187

Reviewed by David Hyatt.

Source/WebCore:

Don't draw the outline if the rectangle to draw is empty.

Test: fast/css/outline-negative.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):

LayoutTests:

Add testcase from bug with small adjustments.

  • fast/css/outline-negative-expected.txt: Added.
  • fast/css/outline-negative.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r154062 r154064  
     12013-08-14  Rob Buis  <rwlbuis@webkit.org>
     2
     3        Assertion failure in RenderObject::drawLineForBoxSide
     4        https://bugs.webkit.org/show_bug.cgi?id=108187
     5
     6        Reviewed by David Hyatt.
     7
     8        Add testcase from bug with small adjustments.
     9
     10        * fast/css/outline-negative-expected.txt: Added.
     11        * fast/css/outline-negative.html: Added.
     12
    1132013-08-14  Andreas Kling  <akling@apple.com>
    214
  • trunk/Source/WebCore/ChangeLog

    r154058 r154064  
     12013-08-14  Rob Buis  <rwlbuis@webkit.org>
     2
     3        Assertion failure in RenderObject::drawLineForBoxSide
     4        https://bugs.webkit.org/show_bug.cgi?id=108187
     5
     6        Reviewed by David Hyatt.
     7
     8        Don't draw the outline if the rectangle to draw is empty.
     9
     10        Test: fast/css/outline-negative.html
     11
     12        * rendering/RenderInline.cpp:
     13        (WebCore::RenderInline::paintOutlineForLine):
     14
    1152013-08-13  Chris Fleizach  <cfleizach@apple.com>
    216
  • trunk/Source/WebCore/rendering/RenderInline.cpp

    r152122 r154064  
    14771477
    14781478    IntRect pixelSnappedBox = pixelSnappedIntRect(box);
     1479    if (pixelSnappedBox.isEmpty())
     1480        return;
    14791481    IntRect pixelSnappedLastLine = pixelSnappedIntRect(paintOffset.x() + lastline.x(), 0, lastline.width(), 0);
    14801482    IntRect pixelSnappedNextLine = pixelSnappedIntRect(paintOffset.x() + nextline.x(), 0, nextline.width(), 0);
Note: See TracChangeset for help on using the changeset viewer.