Changeset 154713 in webkit

Timestamp:

Aug 27, 2013 4:09:28 PM (11 years ago)

Author:

rwlbuis@webkit.org

Message:

feImage fails if referenced node contains radialGradient declaration
​https://bugs.webkit.org/show_bug.cgi?id=118735

Reviewed by Darin Adler.

Source/WebCore:

Only call parent's updateRelativeLengthsInformation for graphics elements.

Tests: svg/custom/feImage-pserver-with-percentage-expected.svg

svg/custom/feImage-pserver-with-percentage.svg

• svg/SVGElement.cpp:

(WebCore::SVGElement::updateRelativeLengthsInformation):

LayoutTests:

Add testcase from bug with small adjustments.

• svg/custom/feImage-pserver-with-percentage-expected.svg: Added.
• svg/custom/feImage-pserver-with-percentage.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/feImage-pserver-with-percentage-expected.svg (added)
• LayoutTests/svg/custom/feImage-pserver-with-percentage.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-08-27  Rob Buis  <rwlbuis@webkit.org>
+
+        feImage fails if referenced node contains radialGradient declaration
+        https://bugs.webkit.org/show_bug.cgi?id=118735
+
+        Reviewed by Darin Adler.
+
+        Add testcase from bug with small adjustments.
+
+        * svg/custom/feImage-pserver-with-percentage-expected.svg: Added.
+        * svg/custom/feImage-pserver-with-percentage.svg: Added.
+
 2013-08-27  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-08-27  Rob Buis  <rwlbuis@webkit.org>
+
+        feImage fails if referenced node contains radialGradient declaration
+        https://bugs.webkit.org/show_bug.cgi?id=118735
+
+        Reviewed by Darin Adler.
+
+        Only call parent's updateRelativeLengthsInformation for graphics elements.
+
+        Tests: svg/custom/feImage-pserver-with-percentage-expected.svg
+               svg/custom/feImage-pserver-with-percentage.svg
+
+        * svg/SVGElement.cpp:
+        (WebCore::SVGElement::updateRelativeLengthsInformation):
+
 2013-08-27  Darin Adler  <darin@apple.com>
 

trunk/Source/WebCore/svg/SVGElement.cpp

@@ -1122 +1122 @@
     }
 
+    if (!element->isSVGGraphicsElement())
+        return;
+
     // Find first styled parent node, and notify it that we've changed our relative length state.
     ContainerNode* node = parentNode();