Changeset 154721 in webkit
- Timestamp:
- Aug 27, 2013 9:00:51 PM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 30 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r154719 r154721 1 2013-08-27 Santosh Mahto <santosh.ma@samsung.com> 2 3 Adding "explicit" keyword in forms related classes constructor 4 https://bugs.webkit.org/show_bug.cgi?id=120366 5 6 Reviewed by Darin Adler. 7 8 Adding "explicit" keyword in constructors. 9 10 * html/BaseButtonInputType.h: 11 (WebCore::BaseButtonInputType::BaseButtonInputType): 12 * html/BaseCheckableInputType.h: 13 (WebCore::BaseCheckableInputType::BaseCheckableInputType): 14 * html/BaseChooserOnlyDateAndTimeInputType.h: 15 (WebCore::BaseChooserOnlyDateAndTimeInputType::BaseChooserOnlyDateAndTimeInputType): 16 * html/BaseClickableWithKeyInputType.h: 17 (WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType): 18 * html/BaseTextInputType.h: 19 (WebCore::BaseTextInputType::BaseTextInputType): 20 * html/ColorInputType.h: 21 (WebCore::ColorInputType::ColorInputType): 22 * html/DateInputType.h: 23 * html/DateTimeInputType.h: 24 (WebCore::DateTimeInputType::DateTimeInputType): 25 * html/DateTimeLocalInputType.h: 26 (WebCore::DateTimeLocalInputType::DateTimeLocalInputType): 27 * html/EmailInputType.h: 28 (WebCore::EmailInputType::EmailInputType): 29 * html/FileInputType.h: 30 * html/HiddenInputType.h: 31 (WebCore::HiddenInputType::HiddenInputType): 32 * html/ImageData.h: 33 * html/ImageInputType.h: 34 * html/InputType.h: 35 (WebCore::InputType::InputType): 36 * html/MediaController.h: 37 * html/MonthInputType.h: 38 (WebCore::MonthInputType::MonthInputType): 39 * html/RadioInputType.h: 40 (WebCore::RadioInputType::RadioInputType): 41 * html/RangeInputType.h: 42 * html/ResetInputType.h: 43 (WebCore::ResetInputType::ResetInputType): 44 * html/SearchInputType.h: 45 * html/SubmitInputType.h: 46 (WebCore::SubmitInputType::SubmitInputType): 47 * html/TelephoneInputType.h: 48 (WebCore::TelephoneInputType::TelephoneInputType): 49 * html/TextFieldInputType.h: 50 * html/TextInputType.h: 51 (WebCore::TextInputType::TextInputType): 52 * html/TimeInputType.h: 53 * html/URLInputType.h: 54 (WebCore::URLInputType::URLInputType): 55 * html/ValidationMessage.h: 56 * html/WeekInputType.h: 57 (WebCore::WeekInputType::WeekInputType): 58 1 59 2013-08-27 Benjamin Poulain <benjamin@webkit.org> 2 60 -
trunk/Source/WebCore/html/BaseButtonInputType.h
r129204 r154721 39 39 class BaseButtonInputType : public BaseClickableWithKeyInputType { 40 40 protected: 41 BaseButtonInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { }41 explicit BaseButtonInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { } 42 42 43 43 private: -
trunk/Source/WebCore/html/BaseCheckableInputType.h
r120679 r154721 39 39 class BaseCheckableInputType : public InputType { 40 40 protected: 41 BaseCheckableInputType(HTMLInputElement* element) : InputType(element) { }41 explicit BaseCheckableInputType(HTMLInputElement* element) : InputType(element) { } 42 42 virtual void handleKeydownEvent(KeyboardEvent*); 43 43 -
trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h
r150876 r154721 37 37 class BaseChooserOnlyDateAndTimeInputType : public BaseDateAndTimeInputType, public DateTimeChooserClient { 38 38 protected: 39 BaseChooserOnlyDateAndTimeInputType(HTMLInputElement* element) : BaseDateAndTimeInputType(element) { }39 explicit BaseChooserOnlyDateAndTimeInputType(HTMLInputElement* element) : BaseDateAndTimeInputType(element) { } 40 40 virtual ~BaseChooserOnlyDateAndTimeInputType(); 41 41 -
trunk/Source/WebCore/html/BaseClickableWithKeyInputType.h
r133427 r154721 45 45 46 46 protected: 47 BaseClickableWithKeyInputType(HTMLInputElement* element) : InputType(element) { }47 explicit BaseClickableWithKeyInputType(HTMLInputElement* element) : InputType(element) { } 48 48 49 49 private: -
trunk/Source/WebCore/html/BaseTextInputType.h
r131969 r154721 40 40 class BaseTextInputType : public TextFieldInputType { 41 41 protected: 42 BaseTextInputType(HTMLInputElement* element) : TextFieldInputType(element) { }42 explicit BaseTextInputType(HTMLInputElement* element) : TextFieldInputType(element) { } 43 43 44 44 private: -
trunk/Source/WebCore/html/ColorInputType.h
r153541 r154721 52 52 53 53 private: 54 ColorInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { }54 explicit ColorInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { } 55 55 virtual void attach() OVERRIDE; 56 56 virtual bool isColorControl() const OVERRIDE; -
trunk/Source/WebCore/html/DateInputType.h
r151947 r154721 42 42 43 43 private: 44 DateInputType(HTMLInputElement*);44 explicit DateInputType(HTMLInputElement*); 45 45 virtual void attach() OVERRIDE; 46 46 virtual const AtomicString& formControlType() const OVERRIDE; -
trunk/Source/WebCore/html/DateTimeInputType.h
r150876 r154721 43 43 44 44 private: 45 DateTimeInputType(HTMLInputElement* element) : BaseDateTimeInputType(element) { }45 explicit DateTimeInputType(HTMLInputElement* element) : BaseDateTimeInputType(element) { } 46 46 virtual void attach() OVERRIDE; 47 47 virtual const AtomicString& formControlType() const OVERRIDE; -
trunk/Source/WebCore/html/DateTimeLocalInputType.h
r150876 r154721 42 42 43 43 private: 44 DateTimeLocalInputType(HTMLInputElement* element) : BaseDateTimeLocalInputType(element) { }44 explicit DateTimeLocalInputType(HTMLInputElement* element) : BaseDateTimeLocalInputType(element) { } 45 45 virtual void attach() OVERRIDE; 46 46 virtual const AtomicString& formControlType() const OVERRIDE; -
trunk/Source/WebCore/html/EmailInputType.h
r141086 r154721 41 41 42 42 private: 43 EmailInputType(HTMLInputElement* element) : BaseTextInputType(element) { }43 explicit EmailInputType(HTMLInputElement* element) : BaseTextInputType(element) { } 44 44 virtual void attach() OVERRIDE; 45 45 virtual const AtomicString& formControlType() const OVERRIDE; -
trunk/Source/WebCore/html/FileInputType.h
r150165 r154721 51 51 52 52 private: 53 FileInputType(HTMLInputElement*);53 explicit FileInputType(HTMLInputElement*); 54 54 55 55 virtual const AtomicString& formControlType() const OVERRIDE; -
trunk/Source/WebCore/html/HiddenInputType.h
r120679 r154721 41 41 42 42 private: 43 HiddenInputType(HTMLInputElement* element) : InputType(element) { }43 explicit HiddenInputType(HTMLInputElement* element) : InputType(element) { } 44 44 virtual const AtomicString& formControlType() const OVERRIDE; 45 45 virtual FormControlState saveFormControlState() const OVERRIDE; -
trunk/Source/WebCore/html/ImageData.h
r153728 r154721 48 48 49 49 private: 50 ImageData(const IntSize&);50 explicit ImageData(const IntSize&); 51 51 ImageData(const IntSize&, PassRefPtr<Uint8ClampedArray>); 52 52 -
trunk/Source/WebCore/html/ImageInputType.h
r151947 r154721 44 44 45 45 private: 46 ImageInputType(HTMLInputElement*);46 explicit ImageInputType(HTMLInputElement*); 47 47 virtual const AtomicString& formControlType() const OVERRIDE; 48 48 virtual bool isFormDataAppendable() const OVERRIDE; -
trunk/Source/WebCore/html/InputType.h
r153647 r154721 313 313 314 314 protected: 315 InputType(HTMLInputElement* element) : m_element(element) { }315 explicit InputType(HTMLInputElement* element) : m_element(element) { } 316 316 HTMLInputElement* element() const { return m_element; } 317 317 Chrome* chrome() const; -
trunk/Source/WebCore/html/MediaController.h
r153926 r154721 115 115 116 116 private: 117 MediaController(ScriptExecutionContext*);117 explicit MediaController(ScriptExecutionContext*); 118 118 void reportControllerState(); 119 119 void updateReadyState(); -
trunk/Source/WebCore/html/MonthInputType.h
r150876 r154721 42 42 43 43 private: 44 MonthInputType(HTMLInputElement* element) : BaseMonthInputType(element) { }44 explicit MonthInputType(HTMLInputElement* element) : BaseMonthInputType(element) { } 45 45 virtual void attach() OVERRIDE; 46 46 virtual const AtomicString& formControlType() const OVERRIDE; -
trunk/Source/WebCore/html/RadioInputType.h
r120695 r154721 41 41 42 42 private: 43 RadioInputType(HTMLInputElement* element) : BaseCheckableInputType(element) { }43 explicit RadioInputType(HTMLInputElement* element) : BaseCheckableInputType(element) { } 44 44 virtual const AtomicString& formControlType() const OVERRIDE; 45 45 virtual bool valueMissing(const String&) const OVERRIDE; -
trunk/Source/WebCore/html/RangeInputType.h
r141086 r154721 43 43 44 44 private: 45 RangeInputType(HTMLInputElement*);45 explicit RangeInputType(HTMLInputElement*); 46 46 virtual void attach() OVERRIDE; 47 47 virtual bool isRangeControl() const OVERRIDE; -
trunk/Source/WebCore/html/ResetInputType.h
r103400 r154721 41 41 42 42 private: 43 ResetInputType(HTMLInputElement* element) : BaseButtonInputType(element) { }43 explicit ResetInputType(HTMLInputElement* element) : BaseButtonInputType(element) { } 44 44 virtual const AtomicString& formControlType() const OVERRIDE; 45 45 virtual bool supportsValidation() const OVERRIDE; -
trunk/Source/WebCore/html/SearchInputType.h
r153647 r154721 47 47 48 48 private: 49 SearchInputType(HTMLInputElement*);49 explicit SearchInputType(HTMLInputElement*); 50 50 virtual void attach() OVERRIDE; 51 51 virtual void addSearchResult() OVERRIDE; -
trunk/Source/WebCore/html/SubmitInputType.h
r103400 r154721 41 41 42 42 private: 43 SubmitInputType(HTMLInputElement* element) : BaseButtonInputType(element) { }43 explicit SubmitInputType(HTMLInputElement* element) : BaseButtonInputType(element) { } 44 44 virtual const AtomicString& formControlType() const OVERRIDE; 45 45 virtual bool appendFormData(FormDataList&, bool) const OVERRIDE; -
trunk/Source/WebCore/html/TelephoneInputType.h
r141086 r154721 41 41 42 42 private: 43 TelephoneInputType(HTMLInputElement* element) : BaseTextInputType(element) { }43 explicit TelephoneInputType(HTMLInputElement* element) : BaseTextInputType(element) { } 44 44 virtual void attach() OVERRIDE; 45 45 virtual const AtomicString& formControlType() const OVERRIDE; -
trunk/Source/WebCore/html/TextFieldInputType.h
r151947 r154721 43 43 class TextFieldInputType : public InputType, protected SpinButtonElement::SpinButtonOwner { 44 44 protected: 45 TextFieldInputType(HTMLInputElement*);45 explicit TextFieldInputType(HTMLInputElement*); 46 46 virtual ~TextFieldInputType(); 47 47 virtual bool canSetSuggestedValue() OVERRIDE; -
trunk/Source/WebCore/html/TextInputType.h
r141086 r154721 41 41 42 42 private: 43 TextInputType(HTMLInputElement* element) : BaseTextInputType(element) { }43 explicit TextInputType(HTMLInputElement* element) : BaseTextInputType(element) { } 44 44 virtual void attach() OVERRIDE; 45 45 virtual const AtomicString& formControlType() const OVERRIDE; -
trunk/Source/WebCore/html/TimeInputType.h
r150876 r154721 42 42 43 43 private: 44 TimeInputType(HTMLInputElement*);44 explicit TimeInputType(HTMLInputElement*); 45 45 virtual void attach() OVERRIDE; 46 46 virtual const AtomicString& formControlType() const OVERRIDE; -
trunk/Source/WebCore/html/URLInputType.h
r141086 r154721 41 41 42 42 private: 43 URLInputType(HTMLInputElement* element) : BaseTextInputType(element) { }43 explicit URLInputType(HTMLInputElement* element) : BaseTextInputType(element) { } 44 44 virtual void attach() OVERRIDE; 45 45 virtual const AtomicString& formControlType() const OVERRIDE; -
trunk/Source/WebCore/html/ValidationMessage.h
r154371 r154721 58 58 59 59 private: 60 ValidationMessage(HTMLFormControlElement*);60 explicit ValidationMessage(HTMLFormControlElement*); 61 61 ValidationMessageClient* validationMessageClient() const; 62 62 void setMessage(const String&); -
trunk/Source/WebCore/html/WeekInputType.h
r150876 r154721 42 42 43 43 private: 44 WeekInputType(HTMLInputElement* element) : BaseWeekInputType(element) { }44 explicit WeekInputType(HTMLInputElement* element) : BaseWeekInputType(element) { } 45 45 virtual void attach() OVERRIDE; 46 46 virtual const AtomicString& formControlType() const OVERRIDE;
Note: See TracChangeset
for help on using the changeset viewer.