Changeset 154721 in webkit


Ignore:
Timestamp:
Aug 27, 2013 9:00:51 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Adding "explicit" keyword in forms related classes constructor
https://bugs.webkit.org/show_bug.cgi?id=120366

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-08-27
Reviewed by Darin Adler.

Adding "explicit" keyword in constructors.

  • html/BaseButtonInputType.h:

(WebCore::BaseButtonInputType::BaseButtonInputType):

  • html/BaseCheckableInputType.h:

(WebCore::BaseCheckableInputType::BaseCheckableInputType):

  • html/BaseChooserOnlyDateAndTimeInputType.h:

(WebCore::BaseChooserOnlyDateAndTimeInputType::BaseChooserOnlyDateAndTimeInputType):

  • html/BaseClickableWithKeyInputType.h:

(WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):

  • html/BaseTextInputType.h:

(WebCore::BaseTextInputType::BaseTextInputType):

  • html/ColorInputType.h:

(WebCore::ColorInputType::ColorInputType):

  • html/DateInputType.h:
  • html/DateTimeInputType.h:

(WebCore::DateTimeInputType::DateTimeInputType):

  • html/DateTimeLocalInputType.h:

(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):

  • html/EmailInputType.h:

(WebCore::EmailInputType::EmailInputType):

  • html/FileInputType.h:
  • html/HiddenInputType.h:

(WebCore::HiddenInputType::HiddenInputType):

  • html/ImageData.h:
  • html/ImageInputType.h:
  • html/InputType.h:

(WebCore::InputType::InputType):

  • html/MediaController.h:
  • html/MonthInputType.h:

(WebCore::MonthInputType::MonthInputType):

  • html/RadioInputType.h:

(WebCore::RadioInputType::RadioInputType):

  • html/RangeInputType.h:
  • html/ResetInputType.h:

(WebCore::ResetInputType::ResetInputType):

  • html/SearchInputType.h:
  • html/SubmitInputType.h:

(WebCore::SubmitInputType::SubmitInputType):

  • html/TelephoneInputType.h:

(WebCore::TelephoneInputType::TelephoneInputType):

  • html/TextFieldInputType.h:
  • html/TextInputType.h:

(WebCore::TextInputType::TextInputType):

  • html/TimeInputType.h:
  • html/URLInputType.h:

(WebCore::URLInputType::URLInputType):

  • html/ValidationMessage.h:
  • html/WeekInputType.h:

(WebCore::WeekInputType::WeekInputType):

Location:
trunk/Source/WebCore
Files:
30 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r154719 r154721  
     12013-08-27  Santosh Mahto  <santosh.ma@samsung.com>
     2
     3        Adding  "explicit" keyword in  forms related classes constructor
     4        https://bugs.webkit.org/show_bug.cgi?id=120366
     5
     6        Reviewed by Darin Adler.
     7
     8        Adding "explicit" keyword in constructors.
     9
     10        * html/BaseButtonInputType.h:
     11        (WebCore::BaseButtonInputType::BaseButtonInputType):
     12        * html/BaseCheckableInputType.h:
     13        (WebCore::BaseCheckableInputType::BaseCheckableInputType):
     14        * html/BaseChooserOnlyDateAndTimeInputType.h:
     15        (WebCore::BaseChooserOnlyDateAndTimeInputType::BaseChooserOnlyDateAndTimeInputType):
     16        * html/BaseClickableWithKeyInputType.h:
     17        (WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):
     18        * html/BaseTextInputType.h:
     19        (WebCore::BaseTextInputType::BaseTextInputType):
     20        * html/ColorInputType.h:
     21        (WebCore::ColorInputType::ColorInputType):
     22        * html/DateInputType.h:
     23        * html/DateTimeInputType.h:
     24        (WebCore::DateTimeInputType::DateTimeInputType):
     25        * html/DateTimeLocalInputType.h:
     26        (WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
     27        * html/EmailInputType.h:
     28        (WebCore::EmailInputType::EmailInputType):
     29        * html/FileInputType.h:
     30        * html/HiddenInputType.h:
     31        (WebCore::HiddenInputType::HiddenInputType):
     32        * html/ImageData.h:
     33        * html/ImageInputType.h:
     34        * html/InputType.h:
     35        (WebCore::InputType::InputType):
     36        * html/MediaController.h:
     37        * html/MonthInputType.h:
     38        (WebCore::MonthInputType::MonthInputType):
     39        * html/RadioInputType.h:
     40        (WebCore::RadioInputType::RadioInputType):
     41        * html/RangeInputType.h:
     42        * html/ResetInputType.h:
     43        (WebCore::ResetInputType::ResetInputType):
     44        * html/SearchInputType.h:
     45        * html/SubmitInputType.h:
     46        (WebCore::SubmitInputType::SubmitInputType):
     47        * html/TelephoneInputType.h:
     48        (WebCore::TelephoneInputType::TelephoneInputType):
     49        * html/TextFieldInputType.h:
     50        * html/TextInputType.h:
     51        (WebCore::TextInputType::TextInputType):
     52        * html/TimeInputType.h:
     53        * html/URLInputType.h:
     54        (WebCore::URLInputType::URLInputType):
     55        * html/ValidationMessage.h:
     56        * html/WeekInputType.h:
     57        (WebCore::WeekInputType::WeekInputType):
     58
    1592013-08-27  Benjamin Poulain  <benjamin@webkit.org>
    260
  • trunk/Source/WebCore/html/BaseButtonInputType.h

    r129204 r154721  
    3939class BaseButtonInputType : public BaseClickableWithKeyInputType {
    4040protected:
    41     BaseButtonInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { }
     41    explicit BaseButtonInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { }
    4242
    4343private:
  • trunk/Source/WebCore/html/BaseCheckableInputType.h

    r120679 r154721  
    3939class BaseCheckableInputType : public InputType {
    4040protected:
    41     BaseCheckableInputType(HTMLInputElement* element) : InputType(element) { }
     41    explicit BaseCheckableInputType(HTMLInputElement* element) : InputType(element) { }
    4242    virtual void handleKeydownEvent(KeyboardEvent*);
    4343
  • trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h

    r150876 r154721  
    3737class BaseChooserOnlyDateAndTimeInputType : public BaseDateAndTimeInputType, public DateTimeChooserClient {
    3838protected:
    39     BaseChooserOnlyDateAndTimeInputType(HTMLInputElement* element) : BaseDateAndTimeInputType(element) { }
     39    explicit BaseChooserOnlyDateAndTimeInputType(HTMLInputElement* element) : BaseDateAndTimeInputType(element) { }
    4040    virtual ~BaseChooserOnlyDateAndTimeInputType();
    4141
  • trunk/Source/WebCore/html/BaseClickableWithKeyInputType.h

    r133427 r154721  
    4545   
    4646protected:
    47     BaseClickableWithKeyInputType(HTMLInputElement* element) : InputType(element) { }
     47    explicit BaseClickableWithKeyInputType(HTMLInputElement* element) : InputType(element) { }
    4848
    4949private:
  • trunk/Source/WebCore/html/BaseTextInputType.h

    r131969 r154721  
    4040class BaseTextInputType : public TextFieldInputType {
    4141protected:
    42     BaseTextInputType(HTMLInputElement* element) : TextFieldInputType(element) { }
     42    explicit BaseTextInputType(HTMLInputElement* element) : TextFieldInputType(element) { }
    4343
    4444private:
  • trunk/Source/WebCore/html/ColorInputType.h

    r153541 r154721  
    5252
    5353private:
    54     ColorInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { }
     54    explicit ColorInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { }
    5555    virtual void attach() OVERRIDE;
    5656    virtual bool isColorControl() const OVERRIDE;
  • trunk/Source/WebCore/html/DateInputType.h

    r151947 r154721  
    4242
    4343private:
    44     DateInputType(HTMLInputElement*);
     44    explicit DateInputType(HTMLInputElement*);
    4545    virtual void attach() OVERRIDE;
    4646    virtual const AtomicString& formControlType() const OVERRIDE;
  • trunk/Source/WebCore/html/DateTimeInputType.h

    r150876 r154721  
    4343
    4444private:
    45     DateTimeInputType(HTMLInputElement* element) : BaseDateTimeInputType(element) { }
     45    explicit DateTimeInputType(HTMLInputElement* element) : BaseDateTimeInputType(element) { }
    4646    virtual void attach() OVERRIDE;
    4747    virtual const AtomicString& formControlType() const OVERRIDE;
  • trunk/Source/WebCore/html/DateTimeLocalInputType.h

    r150876 r154721  
    4242
    4343private:
    44     DateTimeLocalInputType(HTMLInputElement* element) : BaseDateTimeLocalInputType(element) { }
     44    explicit DateTimeLocalInputType(HTMLInputElement* element) : BaseDateTimeLocalInputType(element) { }
    4545    virtual void attach() OVERRIDE;
    4646    virtual const AtomicString& formControlType() const OVERRIDE;
  • trunk/Source/WebCore/html/EmailInputType.h

    r141086 r154721  
    4141
    4242private:
    43     EmailInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
     43    explicit EmailInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
    4444    virtual void attach() OVERRIDE;
    4545    virtual const AtomicString& formControlType() const OVERRIDE;
  • trunk/Source/WebCore/html/FileInputType.h

    r150165 r154721  
    5151
    5252private:
    53     FileInputType(HTMLInputElement*);
     53    explicit FileInputType(HTMLInputElement*);
    5454
    5555    virtual const AtomicString& formControlType() const OVERRIDE;
  • trunk/Source/WebCore/html/HiddenInputType.h

    r120679 r154721  
    4141
    4242private:
    43     HiddenInputType(HTMLInputElement* element) : InputType(element) { }
     43    explicit HiddenInputType(HTMLInputElement* element) : InputType(element) { }
    4444    virtual const AtomicString& formControlType() const OVERRIDE;
    4545    virtual FormControlState saveFormControlState() const OVERRIDE;
  • trunk/Source/WebCore/html/ImageData.h

    r153728 r154721  
    4848
    4949private:
    50     ImageData(const IntSize&);
     50    explicit ImageData(const IntSize&);
    5151    ImageData(const IntSize&, PassRefPtr<Uint8ClampedArray>);
    5252
  • trunk/Source/WebCore/html/ImageInputType.h

    r151947 r154721  
    4444
    4545private:
    46     ImageInputType(HTMLInputElement*);
     46    explicit ImageInputType(HTMLInputElement*);
    4747    virtual const AtomicString& formControlType() const OVERRIDE;
    4848    virtual bool isFormDataAppendable() const OVERRIDE;
  • trunk/Source/WebCore/html/InputType.h

    r153647 r154721  
    313313
    314314protected:
    315     InputType(HTMLInputElement* element) : m_element(element) { }
     315    explicit InputType(HTMLInputElement* element) : m_element(element) { }
    316316    HTMLInputElement* element() const { return m_element; }
    317317    Chrome* chrome() const;
  • trunk/Source/WebCore/html/MediaController.h

    r153926 r154721  
    115115
    116116private:
    117     MediaController(ScriptExecutionContext*);
     117    explicit MediaController(ScriptExecutionContext*);
    118118    void reportControllerState();
    119119    void updateReadyState();
  • trunk/Source/WebCore/html/MonthInputType.h

    r150876 r154721  
    4242
    4343private:
    44     MonthInputType(HTMLInputElement* element) : BaseMonthInputType(element) { }
     44    explicit MonthInputType(HTMLInputElement* element) : BaseMonthInputType(element) { }
    4545    virtual void attach() OVERRIDE;
    4646    virtual const AtomicString& formControlType() const OVERRIDE;
  • trunk/Source/WebCore/html/RadioInputType.h

    r120695 r154721  
    4141
    4242private:
    43     RadioInputType(HTMLInputElement* element) : BaseCheckableInputType(element) { }
     43    explicit RadioInputType(HTMLInputElement* element) : BaseCheckableInputType(element) { }
    4444    virtual const AtomicString& formControlType() const OVERRIDE;
    4545    virtual bool valueMissing(const String&) const OVERRIDE;
  • trunk/Source/WebCore/html/RangeInputType.h

    r141086 r154721  
    4343
    4444private:
    45     RangeInputType(HTMLInputElement*);
     45    explicit RangeInputType(HTMLInputElement*);
    4646    virtual void attach() OVERRIDE;
    4747    virtual bool isRangeControl() const OVERRIDE;
  • trunk/Source/WebCore/html/ResetInputType.h

    r103400 r154721  
    4141
    4242private:
    43     ResetInputType(HTMLInputElement* element) : BaseButtonInputType(element) { }
     43    explicit ResetInputType(HTMLInputElement* element) : BaseButtonInputType(element) { }
    4444    virtual const AtomicString& formControlType() const OVERRIDE;
    4545    virtual bool supportsValidation() const OVERRIDE;
  • trunk/Source/WebCore/html/SearchInputType.h

    r153647 r154721  
    4747
    4848private:
    49     SearchInputType(HTMLInputElement*);
     49    explicit SearchInputType(HTMLInputElement*);
    5050    virtual void attach() OVERRIDE;
    5151    virtual void addSearchResult() OVERRIDE;
  • trunk/Source/WebCore/html/SubmitInputType.h

    r103400 r154721  
    4141
    4242private:
    43     SubmitInputType(HTMLInputElement* element) : BaseButtonInputType(element) { }
     43    explicit SubmitInputType(HTMLInputElement* element) : BaseButtonInputType(element) { }
    4444    virtual const AtomicString& formControlType() const OVERRIDE;
    4545    virtual bool appendFormData(FormDataList&, bool) const OVERRIDE;
  • trunk/Source/WebCore/html/TelephoneInputType.h

    r141086 r154721  
    4141
    4242private:
    43     TelephoneInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
     43    explicit TelephoneInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
    4444    virtual void attach() OVERRIDE;
    4545    virtual const AtomicString& formControlType() const OVERRIDE;
  • trunk/Source/WebCore/html/TextFieldInputType.h

    r151947 r154721  
    4343class TextFieldInputType : public InputType, protected SpinButtonElement::SpinButtonOwner {
    4444protected:
    45     TextFieldInputType(HTMLInputElement*);
     45    explicit TextFieldInputType(HTMLInputElement*);
    4646    virtual ~TextFieldInputType();
    4747    virtual bool canSetSuggestedValue() OVERRIDE;
  • trunk/Source/WebCore/html/TextInputType.h

    r141086 r154721  
    4141
    4242private:
    43     TextInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
     43    explicit TextInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
    4444    virtual void attach() OVERRIDE;
    4545    virtual const AtomicString& formControlType() const OVERRIDE;
  • trunk/Source/WebCore/html/TimeInputType.h

    r150876 r154721  
    4242
    4343private:
    44     TimeInputType(HTMLInputElement*);
     44    explicit TimeInputType(HTMLInputElement*);
    4545    virtual void attach() OVERRIDE;
    4646    virtual const AtomicString& formControlType() const OVERRIDE;
  • trunk/Source/WebCore/html/URLInputType.h

    r141086 r154721  
    4141
    4242private:
    43     URLInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
     43    explicit URLInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
    4444    virtual void attach() OVERRIDE;
    4545    virtual const AtomicString& formControlType() const OVERRIDE;
  • trunk/Source/WebCore/html/ValidationMessage.h

    r154371 r154721  
    5858
    5959private:
    60     ValidationMessage(HTMLFormControlElement*);
     60    explicit ValidationMessage(HTMLFormControlElement*);
    6161    ValidationMessageClient* validationMessageClient() const;
    6262    void setMessage(const String&);
  • trunk/Source/WebCore/html/WeekInputType.h

    r150876 r154721  
    4242
    4343private:
    44     WeekInputType(HTMLInputElement* element) : BaseWeekInputType(element) { }
     44    explicit WeekInputType(HTMLInputElement* element) : BaseWeekInputType(element) { }
    4545    virtual void attach() OVERRIDE;
    4646    virtual const AtomicString& formControlType() const OVERRIDE;
Note: See TracChangeset for help on using the changeset viewer.