Changeset 154976 in webkit
- Timestamp:
- Sep 3, 2013 4:29:33 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 15 edited
- 2 moved
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r154973 r154976 1 2013-09-03 Krzysztof Czech <k.czech@samsung.com> 2 3 [AX][ATK] Added support for sort and help attributes 4 https://bugs.webkit.org/show_bug.cgi?id=120456 5 6 Reviewed by Chris Fleizach. 7 8 Sharing aria-sort.html specific mac test with efl and gtk. 9 Changing specific expectations of some accessibility tests. 10 11 * accessibility/aria-sort-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-sort-expected.txt. 12 * accessibility/aria-sort.html: Renamed from LayoutTests/platform/mac/accessibility/aria-sort.html. 13 * platform/efl-wk2/TestExpectations: 14 * platform/efl-wk2/accessibility/image-link-expected.txt: 15 * platform/efl-wk2/accessibility/image-map2-expected.txt: 16 * platform/efl-wk2/accessibility/table-cell-spans-expected.txt: 17 * platform/efl-wk2/accessibility/table-cells-expected.txt: 18 * platform/gtk/accessibility/image-link-expected.txt: 19 * platform/gtk/accessibility/image-map2-expected.txt: 20 * platform/gtk/accessibility/table-cell-spans-expected.txt: 21 * platform/gtk/accessibility/table-cells-expected.txt: 22 1 23 2013-09-03 Mihnea Ovidenie <mihnea@adobe.com> 2 24 -
trunk/LayoutTests/accessibility/aria-sort.html
r154975 r154976 2 2 <html> 3 3 <head> 4 <script src="../ ../../fast/js/resources/js-test-pre.js"></script>4 <script src="../fast/js/resources/js-test-pre.js"></script> 5 5 </head> 6 6 <body id="body"> … … 36 36 </script> 37 37 38 <script src="../ ../../fast/js/resources/js-test-post.js"></script>38 <script src="../fast/js/resources/js-test-post.js"></script> 39 39 </body> 40 40 </html> -
trunk/LayoutTests/platform/efl-wk2/TestExpectations
r154093 r154976 218 218 # Missing EFL's accessibility functions 219 219 webkit.org/b/112027 accessibility/aria-describedby-on-input.html [ Failure ] 220 webkit.org/b/112028 accessibility/aria-help.html [ Failure ]221 220 webkit.org/b/111984 accessibility/aria-hidden-updates-alldescendants.html [ Failure ] 222 221 webkit.org/b/111986 accessibility/aria-invalid.html [ Failure ] -
trunk/LayoutTests/platform/efl-wk2/accessibility/image-link-expected.txt
r154680 r154976 21 21 AXRequired: 0 22 22 AXChecked: 0 23 AXPlatformAttributes: html-id:test, toolkit:WebKitEfl23 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, html-id:test, toolkit:WebKitEfl 24 24 25 25 Child 0: … … 40 40 AXRequired: 0 41 41 AXChecked: 0 42 AXPlatformAttributes: toolkit:WebKitEfl42 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 43 43 44 44 -
trunk/LayoutTests/platform/efl-wk2/accessibility/image-map2-expected.txt
r154680 r154976 18 18 AXRequired: 0 19 19 AXChecked: 0 20 AXPlatformAttributes: html-id:result, toolkit:WebKitEfl20 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, html-id:result, toolkit:WebKitEfl 21 21 ------------ 22 22 AXRole: AXLink … … 36 36 AXRequired: 0 37 37 AXChecked: 0 38 AXPlatformAttributes: toolkit:WebKitEfl38 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 39 39 ------------ 40 40 AXRole: AXLink … … 54 54 AXRequired: 0 55 55 AXChecked: 0 56 AXPlatformAttributes: toolkit:WebKitEfl56 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 57 57 ------------ 58 58 -
trunk/LayoutTests/platform/efl-wk2/accessibility/table-cell-spans-expected.txt
r154680 r154976 26 26 AXRequired: 0 27 27 AXChecked: 0 28 AXPlatformAttributes: toolkit:WebKitEfl28 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 29 29 {0, 2}, {0, 2} 30 30 … … 48 48 AXRequired: 0 49 49 AXChecked: 0 50 AXPlatformAttributes: toolkit:WebKitEfl50 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 51 51 {0, 2}, {0, 2} 52 52 … … 70 70 AXRequired: 0 71 71 AXChecked: 0 72 AXPlatformAttributes: toolkit:WebKitEfl72 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 73 73 {2, 2}, {0, 1} 74 74 … … 92 92 AXRequired: 0 93 93 AXChecked: 0 94 AXPlatformAttributes: toolkit:WebKitEfl94 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 95 95 {2, 2}, {0, 1} 96 96 … … 114 114 AXRequired: 0 115 115 AXChecked: 0 116 AXPlatformAttributes: toolkit:WebKitEfl116 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 117 117 {2, 1}, {3, 1} 118 118 -
trunk/LayoutTests/platform/efl-wk2/accessibility/table-cells-expected.txt
r154680 r154976 28 28 AXRequired: 0 29 29 AXChecked: 0 30 AXPlatformAttributes: toolkit:WebKitEfl30 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 31 31 ------------------------ 32 32 [3,1] … … 48 48 AXRequired: 0 49 49 AXChecked: 0 50 AXPlatformAttributes: toolkit:WebKitEfl50 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 51 51 ------------------------ 52 52 [1,1] … … 68 68 AXRequired: 0 69 69 AXChecked: 0 70 AXPlatformAttributes: toolkit:WebKitEfl70 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 71 71 ------------------------ 72 72 [2,2] … … 88 88 AXRequired: 0 89 89 AXChecked: 0 90 AXPlatformAttributes: toolkit:WebKitEfl90 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 91 91 ------------------------ 92 92 [3,5] … … 108 108 AXRequired: 0 109 109 AXChecked: 0 110 AXPlatformAttributes: toolkit:WebKitEfl110 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitEfl 111 111 ------------------------ 112 112 [100,0] -
trunk/LayoutTests/platform/gtk/accessibility/image-link-expected.txt
r153432 r154976 21 21 AXRequired: 0 22 22 AXChecked: 0 23 AXPlatformAttributes: html-id:test, toolkit:WebKitGtk23 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, html-id:test, toolkit:WebKitGtk 24 24 25 25 Child 0: … … 40 40 AXRequired: 0 41 41 AXChecked: 0 42 AXPlatformAttributes: toolkit:WebKitGtk42 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 43 43 44 44 -
trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt
r153435 r154976 18 18 AXRequired: 0 19 19 AXChecked: 0 20 AXPlatformAttributes: html-id:result, toolkit:WebKitGtk20 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, html-id:result, toolkit:WebKitGtk 21 21 ------------ 22 22 AXRole: AXLink … … 36 36 AXRequired: 0 37 37 AXChecked: 0 38 AXPlatformAttributes: toolkit:WebKitGtk38 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 39 39 ------------ 40 40 AXRole: AXLink … … 54 54 AXRequired: 0 55 55 AXChecked: 0 56 AXPlatformAttributes: toolkit:WebKitGtk56 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 57 57 ------------ 58 58 -
trunk/LayoutTests/platform/gtk/accessibility/table-cell-spans-expected.txt
r153432 r154976 26 26 AXRequired: 0 27 27 AXChecked: 0 28 AXPlatformAttributes: toolkit:WebKitGtk28 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 29 29 {0, 2}, {0, 2} 30 30 … … 48 48 AXRequired: 0 49 49 AXChecked: 0 50 AXPlatformAttributes: toolkit:WebKitGtk50 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 51 51 {0, 2}, {0, 2} 52 52 … … 70 70 AXRequired: 0 71 71 AXChecked: 0 72 AXPlatformAttributes: toolkit:WebKitGtk72 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 73 73 {2, 2}, {0, 1} 74 74 … … 92 92 AXRequired: 0 93 93 AXChecked: 0 94 AXPlatformAttributes: toolkit:WebKitGtk94 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 95 95 {2, 2}, {0, 1} 96 96 … … 114 114 AXRequired: 0 115 115 AXChecked: 0 116 AXPlatformAttributes: toolkit:WebKitGtk116 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 117 117 {2, 1}, {3, 1} 118 118 -
trunk/LayoutTests/platform/gtk/accessibility/table-cells-expected.txt
r153432 r154976 28 28 AXRequired: 0 29 29 AXChecked: 0 30 AXPlatformAttributes: toolkit:WebKitGtk30 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 31 31 ------------------------ 32 32 [3,1] … … 48 48 AXRequired: 0 49 49 AXChecked: 0 50 AXPlatformAttributes: toolkit:WebKitGtk50 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 51 51 ------------------------ 52 52 [1,1] … … 68 68 AXRequired: 0 69 69 AXChecked: 0 70 AXPlatformAttributes: toolkit:WebKitGtk70 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 71 71 ------------------------ 72 72 [2,2] … … 88 88 AXRequired: 0 89 89 AXChecked: 0 90 AXPlatformAttributes: toolkit:WebKitGtk90 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 91 91 ------------------------ 92 92 [3,5] … … 108 108 AXRequired: 0 109 109 AXChecked: 0 110 AXPlatformAttributes: toolkit:WebKitGtk110 AXPlatformAttributes: aria-sort:AXUnknownSortDirection, toolkit:WebKitGtk 111 111 ------------------------ 112 112 [100,0] -
trunk/Source/WebCore/ChangeLog
r154975 r154976 1 2013-09-03 Krzysztof Czech <k.czech@samsung.com> 2 3 [AX][ATK] Added support for sort and help attributes. 4 https://bugs.webkit.org/show_bug.cgi?id=120456 5 6 Reviewed by Chris Fleizach. 7 8 Added support for aria-sort and aria-help attributes. 9 10 Test: accessibility/aria-sort.html 11 12 * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: 13 (webkitAccessibleGetAttributes): 14 1 15 2013-09-03 Allan Sandfeld Jensen <allan.jensen@digia.com> 2 16 -
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
r154960 r154976 502 502 if (!invalidStatus.isEmpty() && invalidStatus != "false") 503 503 attributeSet = addToAtkAttributeSet(attributeSet, "aria-invalid", coreObject->invalidStatus().string().utf8().data()); 504 505 String helpText = coreObject->helpText(); 506 if (!helpText.isEmpty()) 507 attributeSet = addToAtkAttributeSet(attributeSet, "aria-help", helpText.utf8().data()); 508 509 const char* sortDescription = "AXUnknownSortDirection"; 510 AccessibilitySortDirection sortDirection = coreObject->sortDirection(); 511 if (sortDirection == SortDirectionAscending) 512 sortDescription = "AXAscendingSortDirection"; 513 else if (sortDirection == SortDirectionDescending) 514 sortDescription = "AXDescendingSortDirection"; 515 516 attributeSet = addToAtkAttributeSet(attributeSet, "aria-sort", sortDescription); 504 517 505 518 return attributeSet; -
trunk/Tools/ChangeLog
r154974 r154976 1 2013-09-03 Krzysztof Czech <k.czech@samsung.com> 2 3 [AX][ATK] Added support for sort and help attributes 4 https://bugs.webkit.org/show_bug.cgi?id=120456 5 6 Reviewed by Chris Fleizach. 7 8 Added missing implementation to AccessibilityUIElement::helpText and support for 9 aria-sort attribute. 10 11 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: 12 (coreAttributeToAtkAttribute): 13 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: 14 (WTR::coreAttributeToAtkAttribute): 15 (WTR::AccessibilityUIElement::helpText): 16 1 17 2013-09-03 Allan Sandfeld Jensen <allan.jensen@digia.com> 2 18 -
trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
r154960 r154976 54 54 if (attributeString == "AXPlaceholderValue") 55 55 return "placeholder-text"; 56 57 if (attributeString == "AXSortDirection") 58 return "aria-sort"; 56 59 57 60 return String(); -
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
r154960 r154976 58 58 if (attributeString == "AXPlaceholderValue") 59 59 return "placeholder-text"; 60 61 if (attributeString == "AXSortDirection") 62 return "aria-sort"; 60 63 61 64 return String(); … … 693 696 JSRetainPtr<JSStringRef> AccessibilityUIElement::helpText() const 694 697 { 695 // FIXME: implement 696 // We need a way to call WebCore::AccessibilityObject::helpText() 697 // from here, probably a new helper class in WebProcess/WebCoreSupport. 698 return JSStringCreateWithCharacters(0, 0); 698 if (!m_element || !ATK_IS_OBJECT(m_element.get())) 699 return JSStringCreateWithCharacters(0, 0); 700 701 String attributeValue = getAttributeSetValueForId(ATK_OBJECT(m_element.get()), "aria-help"); 702 GOwnPtr<char> axValue(g_strdup_printf("AXHelp: %s", attributeValue.utf8().data())); 703 return JSStringCreateWithUTF8CString(axValue.get()); 699 704 } 700 705
Note: See TracChangeset
for help on using the changeset viewer.