Changeset 154977 in webkit


Ignore:
Timestamp:
Sep 3, 2013 6:16:54 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[gstreamer] Disable HTTP request "Accept-Encoding:" header field on gstreamer source element to avoid receiving the wrong size when retrieving data
​https://bugs.webkit.org/show_bug.cgi?id=115354

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-03
Reviewed by Philippe Normand.

Source/WebCore:

Also disable Accept-Encoding on ResourceRequest::toSoupMessage accordingly.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::toSoupMessage):
Call ResourceRequest::updateSoupMessage from ResourceRequest::toSoupMessage so that the
Accept-Encoding header is also respected.

LayoutTests:

Add test to check that video requests will send no "Accept-Encoding" header.

  • http/tests/media/video-accept-encoding-expected.txt: Added.
  • http/tests/media/video-accept-encoding.cgi: Added.
  • http/tests/media/video-accept-encoding.html: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r154976 r154977  
     12013-09-03  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
     2
     3        [gstreamer] Disable HTTP request "Accept-Encoding:" header field on gstreamer source element to avoid receiving the wrong size when retrieving data
     4        https://bugs.webkit.org/show_bug.cgi?id=115354
     5
     6        Reviewed by Philippe Normand.
     7
     8        Add test to check that video requests will send no "Accept-Encoding" header.
     9
     10        * http/tests/media/video-accept-encoding-expected.txt: Added.
     11        * http/tests/media/video-accept-encoding.cgi: Added.
     12        * http/tests/media/video-accept-encoding.html: Added.
     13
    1142013-09-03  Krzysztof Czech  <k.czech@samsung.com>
    215

  • trunk/Source/WebCore/ChangeLog

    r154976 r154977  
     12013-09-03  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
     2
     3        [gstreamer] Disable HTTP request "Accept-Encoding:" header field on gstreamer source element to avoid receiving the wrong size when retrieving data
     4        https://bugs.webkit.org/show_bug.cgi?id=115354
     5
     6        Reviewed by Philippe Normand.
     7
     8        Also disable Accept-Encoding on ResourceRequest::toSoupMessage accordingly.
     9
     10        * platform/network/soup/ResourceRequestSoup.cpp:
     11        (WebCore::ResourceRequest::toSoupMessage):
     12        Call ResourceRequest::updateSoupMessage from ResourceRequest::toSoupMessage so that the
     13        Accept-Encoding header is also respected.
     14
    1152013-09-03  Krzysztof Czech  <k.czech@samsung.com>
    216

  • trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp

    r153795 r154977  
    8181        return 0;
    8282
    83     updateSoupMessageHeaders(soupMessage->request_headers);
    84 
    85     String firstPartyString = firstPartyForCookies().string();
    86     if (!firstPartyString.isEmpty()) {
    87         GOwnPtr<SoupURI> firstParty(soup_uri_new(firstPartyString.utf8().data()));
    88         soup_message_set_first_party(soupMessage, firstParty.get());
    89     }
    90 
    91     soup_message_set_flags(soupMessage, m_soupFlags);
     83    updateSoupMessage(soupMessage);
    9284
    9385    // Body data is only handled at ResourceHandleSoup::startHttp for
Note: See TracChangeset for help on using the changeset viewer.