Changeset 155014 in webkit

Timestamp:

Sep 3, 2013 6:13:08 PM (11 years ago)

Author:

enrica@apple.com

Message:

Can't select Katakana word by double-clicking.
<rdar://problem/14654926>

Reviewed by Alexey Proskuryakov and Ryosuke Niwa.

Source/WebCore:

For some languages, like Japanese we need
to use more context for word breaking.

New test: editing/selection/doubleclick-japanese-text.html

• platform/text/TextBoundaries.h:

(WebCore::requiresContextForWordBoundary):

Source/WTF:

For some languages, like Japanese we need
to use more context for word breaking.
I've renamed the function to better reflect its use
and remove the unused hasLineBreakingPropertyComplexContextOrIdeographic.

• wtf/unicode/icu/UnicodeIcu.h:

(WTF::Unicode::requiresComplexContextForWordBreaking):

LayoutTests:

Added new test for this scenario.

• editing/selection/doubleclick-japanese-text-expected.txt: Added.
• editing/selection/doubleclick-japanese-text.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/selection/doubleclick-japanese-text-expected.txt (added)
• LayoutTests/editing/selection/doubleclick-japanese-text.html (added)
• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/unicode/icu/UnicodeIcu.h (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/text/TextBoundaries.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-09-03  Enrica Casucci  <enrica@apple.com>
+
+        Can't select Katakana word by double-clicking.
+        <rdar://problem/14654926>
+
+        Reviewed by Alexey Proskuryakov and Ryosuke Niwa.
+
+        Added new test for this scenario.
+
+        * editing/selection/doubleclick-japanese-text-expected.txt: Added.
+        * editing/selection/doubleclick-japanese-text.html: Added.
+
 2013-09-03  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-09-03  Enrica Casucci  <enrica@apple.com>
+
+        Can't select Katakana word by double-clicking.
+        <rdar://problem/14654926>
+
+        Reviewed by Alexey Proskuryakov and Ryosuke Niwa.
+
+        For some languages, like Japanese we need
+        to use more context for word breaking.
+        I've renamed the function to better reflect its use
+        and remove the unused hasLineBreakingPropertyComplexContextOrIdeographic.
+
+        * wtf/unicode/icu/UnicodeIcu.h:
+        (WTF::Unicode::requiresComplexContextForWordBreaking):
+
 2013-09-03  Andreas Kling  <akling@apple.com>
 

trunk/Source/WTF/wtf/unicode/icu/UnicodeIcu.h

@@ -189 +189 @@
 }
 
-inline bool hasLineBreakingPropertyComplexContext(UChar32 c)
-{
-    return u_getIntPropertyValue(c, UCHAR_LINE_BREAK) == U_LB_COMPLEX_CONTEXT;
-}
-
-inline bool hasLineBreakingPropertyComplexContextOrIdeographic(UChar32 c)
+#define WK_LB_CONDITIONAL_JAPANESE_STARTER 37
+
+inline bool requiresComplexContextForWordBreaking(UChar32 c)
 {
     int32_t prop = u_getIntPropertyValue(c, UCHAR_LINE_BREAK);
-    return prop == U_LB_COMPLEX_CONTEXT || prop == U_LB_IDEOGRAPHIC;
+    return prop == U_LB_COMPLEX_CONTEXT || prop == WK_LB_CONDITIONAL_JAPANESE_STARTER || prop == U_LB_IDEOGRAPHIC;
 }
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-09-03  Enrica Casucci  <enrica@apple.com>
+
+        Can't select Katakana word by double-clicking.
+        <rdar://problem/14654926>
+
+        Reviewed by Alexey Proskuryakov and Ryosuke Niwa.
+
+        For some languages, like Japanese we need
+        to use more context for word breaking.
+
+        New test: editing/selection/doubleclick-japanese-text.html
+
+        * platform/text/TextBoundaries.h:
+        (WebCore::requiresContextForWordBoundary):
+
 2013-09-03  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/WebCore/platform/text/TextBoundaries.h

@@ -31 +31 @@
 namespace WebCore {
 
+    // FIXME: this function won't be needed together with the function
+    // it calls when https://bugs.webkit.org/show_bug.cgi?id=120656
+    // will be fixed.
     inline bool requiresContextForWordBoundary(UChar32 ch)
     {
-        return WTF::Unicode::hasLineBreakingPropertyComplexContext(ch);
+        return WTF::Unicode::requiresComplexContextForWordBreaking(ch);
     }