Changeset 155024 in webkit


Ignore:
Timestamp:
Sep 4, 2013 1:21:17 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[GStreamer] cannot play live streams
​https://bugs.webkit.org/show_bug.cgi?id=116831

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-04
Reviewed by Philippe Normand.

Source/WebCore:

Fix issues with rtsp streams embedded on <video> not loading.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

Do not reset pipeline to READY state on STATE_CHANGE_ASYNC when entering PAUSED state for
live streams, otherwise we enter an endless loop of READY->PAUSED->READY->PAUSED when
starting playback.

Tools:

Fix timeout issues with rtspsrc/udpsrc gstreamer elements.

  • gtk/jhbuild.modules:
  • gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Added.
  • gtk/patches/udpsrc-improve-timeouts.patch: Added.

Changed gstreamer jhbuild modules to use tarball repos (required to add patches)
and added 2 patches to gst-plugins-good to fix timeout issues with rtsp streams.
Both patches are applied upstream and can be removed once a new gstreamer release
is out (up to 1.0.10 the patches are not included) and we bump the requirements.

Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r155022 r155024  
     12013-09-04  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
     2
     3        [GStreamer] cannot play live streams
     4        https://bugs.webkit.org/show_bug.cgi?id=116831
     5
     6        Reviewed by Philippe Normand.
     7
     8        Fix issues with rtsp streams embedded on <video> not loading.
     9
     10        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
     11        Do not reset pipeline to READY state on STATE_CHANGE_ASYNC when entering PAUSED state for
     12        live streams, otherwise we enter an endless loop of READY->PAUSED->READY->PAUSED when
     13        starting playback.
     14
    1152013-09-03  Chris Fleizach  <cfleizach@apple.com>
    216

  • trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

    r154988 r155024  
    13121312        LOG_MEDIA_MESSAGE("Async: State: %s, pending: %s", gst_element_state_get_name(state), gst_element_state_get_name(pending));
    13131313        // Change in progress.
    1314 
    1315         // A live stream was paused, reset the pipeline.
    1316         if (state == GST_STATE_PAUSED && pending == GST_STATE_PLAYING && isLiveStream()) {
    1317             changePipelineState(GST_STATE_READY);
    1318             changePipelineState(GST_STATE_PLAYING);
    1319         }
    1320 
    13211314        break;
    13221315    case GST_STATE_CHANGE_FAILURE:

  • trunk/Tools/ChangeLog

    r155000 r155024  
     12013-09-04  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
     2
     3        [GStreamer] cannot play live streams
     4        https://bugs.webkit.org/show_bug.cgi?id=116831
     5
     6        Reviewed by Philippe Normand.
     7
     8        Fix timeout issues with rtspsrc/udpsrc gstreamer elements.
     9
     10        * gtk/jhbuild.modules:
     11        * gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Added.
     12        * gtk/patches/udpsrc-improve-timeouts.patch: Added.
     13        Changed gstreamer jhbuild modules to use tarball repos (required to add patches)
     14        and added 2 patches to gst-plugins-good to fix timeout issues with rtsp streams.
     15        Both patches are applied upstream and can be removed once a new gstreamer release
     16        is out (up to 1.0.10 the patches are not included) and we bump the requirements.
     17
    1182013-09-03  Alexey Proskuryakov  <ap@apple.com>
    219

  • trunk/Tools/gtk/jhbuild.modules

    r154972 r155024  
    5353  <repository type="tarball" name="xmlsoft.org"
    5454      href="ftp://xmlsoft.org"/>
    55   <repository type="git" name="gstreamer"
    56       href="git://anongit.freedesktop.org/git/gstreamer/"/>
     55  <repository type="tarball" name="gstreamer"
     56      href="http://gstreamer.freedesktop.org/src/"/>
    5757  <repository type="tarball" name="savannah.gnu.org"
    5858      href="http://download.savannah.gnu.org/releases/"/>
    … …  
    269269
    270270  <autotools id="gstreamer">
    271     <branch repo="gstreamer" module="gstreamer" checkoutdir="gstreamer" tag="1.0.8"/>
     271    <branch module="gstreamer/gstreamer-1.0.8.tar.xz" version="1.0.8"
     272            repo="gstreamer"
     273            hash="sha256:ff70f45509566b88e35986971ace5e89cb6cb232e9ca249f84502abceef1762d"
     274            md5sum="fb0c73470e8dd5dab01e5e9e62db9db9"/>
    272275  </autotools>
    273276
    … …  
    276279      <dep package="gstreamer"/>
    277280    </dependencies>
    278     <branch repo="gstreamer" module="gst-plugins-base" checkoutdir="gst-plugins-base" tag="1.0.8"/>
     281    <branch module="gst-plugins-base/gst-plugins-base-1.0.8.tar.xz" version="1.0.8"
     282            repo="gstreamer"
     283            hash="sha256:b55c9deea00acf789f82845c088b7c7c17b3ecef24a94831a819071b3dd8ef0d"
     284            md5sum="c8b36678186e7d4fb1e6395ffcd1abb1"/>
    279285  </autotools>
    280286
    … …  
    283289      <dep package="gst-plugins-base"/>
    284290    </dependencies>
    285     <branch repo="gstreamer" module="gst-plugins-good" checkoutdir="gst-plugins-good" tag="1.0.8"/>
     291
     292    <branch module="gst-plugins-good/gst-plugins-good-1.0.8.tar.xz" version="1.0.8"
     293            repo="gstreamer"
     294            hash="sha256:97831570ccdd8e15557f18858b965e54433d572d27fdabebb8b710cee276cfad"
     295            md5sum="4969826043bbd3f76e4a0d49ea475736">
     296      <patch file="udpsrc-improve-timeouts.patch" strip="1"/>
     297      <patch file="rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch" strip="1"/>
     298    </branch>
    286299  </autotools>
    287300
    … …  
    290303      <dep package="gst-plugins-base"/>
    291304    </dependencies>
    292     <branch repo="gstreamer" module="gst-plugins-bad" checkoutdir="gst-plugins-bad" tag="1.0.8"/>
     305    <branch module="gst-plugins-bad/gst-plugins-bad-1.0.8.tar.xz" version="1.0.8"
     306            repo="gstreamer"
     307            hash="sha256:6949b5532034fc37d5a874e4e3330107767238bc4def9f769b8193124e2420cc"
     308            md5sum="a2fdf125ee2ae46047dcbcfc305949ee"/>
    293309  </autotools>
    294310
    … …  
    297313      <dep package="gst-plugins-base"/>
    298314    </dependencies>
    299     <branch repo="gstreamer" module="gst-libav" checkoutdir="gst-libav" tag="1.0.8"/>
     315    <branch module="gst-libav/gst-libav-1.0.8.tar.xz" version="1.0.8"
     316            repo="gstreamer"
     317            hash="sha256:e6e538290e585c993609337761d894dd1b6b53ef625798b2a511d5314579995f"
     318            md5sum="7c2e8db039efa1880a61a6982a6909d7"/>
    300319  </autotools>
    301320
Note: See TracChangeset for help on using the changeset viewer.