Changeset 155235 in webkit

Timestamp:

Sep 6, 2013 9:40:50 PM (11 years ago)

Author:

rniwa@webkit.org

Message:

Unreviewed, rolling out r155196.
​http://trac.webkit.org/changeset/155196
​https://bugs.webkit.org/show_bug.cgi?id=120919

Broke 16 tests on build.webkit.org (Requested by rniwa on
#webkit).

Patch by Commit Queue <​commit-queue@webkit.org> on 2013-09-06

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._set_up_run):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/controllers/manager.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-09-06  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r155196.
+        http://trac.webkit.org/changeset/155196
+        https://bugs.webkit.org/show_bug.cgi?id=120919
+
+        Broke 16 tests on build.webkit.org (Requested by rniwa on
+        #webkit).
+
+        * Scripts/webkitpy/layout_tests/controllers/manager.py:
+        (Manager._set_up_run):
+
 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -150 +150 @@
         # This must be started before we check the system dependencies,
         # since the helper may do things to make the setup correct.
-        self._printer.write_update("Starting pixel test helper ...")
-        self._port.start_helper()
+        if self._options.pixel_tests:
+            self._printer.write_update("Starting pixel test helper ...")
+            self._port.start_helper()
 
         # Check that the system dependencies (themes, fonts, ...) are correct.