Changeset 155411 in webkit


Ignore:
Timestamp:
Sep 9, 2013 7:46:55 PM (11 years ago)
Author:
mark.lam@apple.com
Message:

Tools: Re-landing r155392 (Point Tools scripts to LayoutTests/resources).
​https://bugs.webkit.org/show_bug.cgi?id=120899.

Not reviewed.

The webkitpy test failure that resulted in the rollout is due to
update_webgl_conformance_tests_unittest.py referencing js-test-style.css
which is to be deleted. Deleting that line fixes the issue.

  • Scripts/make-new-script-test:

(makePathToSharedSources):

  • Scripts/run-fast-jsc:
  • Scripts/webkitperl/httpd.pm:

(getDefaultConfigForTestDirectory):

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd.init):

  • Scripts/webkitpy/layout_tests/servers/http_server.py:

(Lighttpd.init):

  • Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:

(BaseTest.integration_test_port_and_root):

  • Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:

(TestHttpServer.test_start_cmd):

  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:

(translate_includes):

  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:

(TestTranslation.test_include_rewriting):

LayoutTests: Re-landing 155392 (Remove old fast/js/resources pre and post test files).
​https://bugs.webkit.org/show_bug.cgi?id=120899.

Not reviewed.

  • fast/js/resources/js-test-post-async.js: Removed.
  • fast/js/resources/js-test-post.js: Removed.
  • fast/js/resources/js-test-pre.js: Removed.
  • fast/js/resources/standalone-post.js: Removed.
  • fast/js/resources/standalone-pre.js: Removed.
Location:
trunk
Files:
5 deleted
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r155410 r155411  
     12013-09-09  Mark Lam  <mark.lam@apple.com>
     2
     3        Re-landing 155392 (Remove old fast/js/resources pre and post test files).
     4        https://bugs.webkit.org/show_bug.cgi?id=120899.
     5
     6        Not reviewed.
     7
     8        * fast/js/resources/js-test-post-async.js: Removed.
     9        * fast/js/resources/js-test-post.js: Removed.
     10        * fast/js/resources/js-test-pre.js: Removed.
     11        * fast/js/resources/standalone-post.js: Removed.
     12        * fast/js/resources/standalone-pre.js: Removed.
     13
    1142013-09-09  Mark Lam  <mark.lam@apple.com>
    215

  • trunk/Tools/ChangeLog

    r155404 r155411  
     12013-09-09  Mark Lam  <mark.lam@apple.com>
     2
     3        Re-landing r155392 (Point Tools scripts to LayoutTests/resources).
     4        https://bugs.webkit.org/show_bug.cgi?id=120899.
     5
     6        Not reviewed.
     7
     8        The webkitpy test failure that resulted in the rollout is due to
     9        update_webgl_conformance_tests_unittest.py referencing js-test-style.css
     10        which is to be deleted. Deleting that line fixes the issue.
     11
     12        * Scripts/make-new-script-test:
     13        (makePathToSharedSources):
     14        * Scripts/run-fast-jsc:
     15        * Scripts/webkitperl/httpd.pm:
     16        (getDefaultConfigForTestDirectory):
     17        * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
     18        (LayoutTestApacheHttpd.__init__):
     19        * Scripts/webkitpy/layout_tests/servers/http_server.py:
     20        (Lighttpd.__init__):
     21        * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
     22        (BaseTest.integration_test_port_and_root):
     23        * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
     24        (TestHttpServer.test_start_cmd):
     25        * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
     26        (translate_includes):
     27        * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
     28        (TestTranslation.test_include_rewriting):
     29
    1302013-09-09  Mark Lam  <mark.lam@apple.com>
    231

  • trunk/Tools/Scripts/make-new-script-test

    r155404 r155411  
    8181        return "/js-test-resources";
    8282    } else {
    83         return File::Spec->abs2rel("fast/js/resources/", dirname($testAbsolutePath));
     83        return File::Spec->abs2rel("resources/", dirname($testAbsolutePath));
    8484    }
    8585}

  • trunk/Tools/Scripts/run-fast-jsc

    r155404 r155411  
    7575fi
    7676
    77 preScript=$testRoot/fast/js/resources/standalone-pre.js
    78 postScript=$testRoot/fast/js/resources/standalone-post.js
     77preScript=$testRoot/resources/standalone-pre.js
     78postScript=$testRoot/resources/standalone-post.js
    7979passList=$resultsRoot/passed
    8080failList=$resultsRoot/failed

  • trunk/Tools/Scripts/webkitperl/httpd.pm

    r155404 r155411  
    106106    my $httpdConfig = getHTTPDConfigPathForTestDirectory($testDirectory);
    107107    my $documentRoot = "$testDirectory/http/tests";
    108     my $jsTestResourcesDirectory = $testDirectory . "/fast/js/resources";
     108    my $jsTestResourcesDirectory = $testDirectory . "/resources";
    109109    my $mediaResourcesDirectory = $testDirectory . "/media";
    110110    my $typesConfig = "$testDirectory/http/conf/mime.types";

  • trunk/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py

    r155404 r155411  
    6161
    6262        test_dir = self._port_obj.layout_tests_dir()
    63         js_test_resources_dir = self._filesystem.join(test_dir, "fast", "js", "resources")
     63        js_test_resources_dir = self._filesystem.join(test_dir, "resources")
    6464        media_resources_dir = self._filesystem.join(test_dir, "media")
    6565        mime_types_path = self._filesystem.join(test_dir, "http", "conf", "mime.types")

  • trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server.py

    r155404 r155411  
    6666
    6767        self._webkit_tests = os.path.join(self._layout_tests_dir, 'http', 'tests')
    68         self._js_test_resource = os.path.join(self._layout_tests_dir, 'fast', 'js', 'resources')
     68        self._js_test_resource = os.path.join(self._layout_tests_dir, 'resources')
    6969        self._media_resource = os.path.join(self._layout_tests_dir, 'media')
    7070

  • trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py

    r155404 r155411  
    121121        tmpdir = tempfile.mkdtemp(prefix='webkitpytest')
    122122        self.maybe_make_dir(tmpdir, 'http', 'tests', 'websocket')
    123         self.maybe_make_dir(tmpdir, 'fast', 'js', 'resources')
     123        self.maybe_make_dir(tmpdir, 'resources')
    124124        self.maybe_make_dir(tmpdir, 'media')
    125125

  • trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py

    r155404 r155411  
    5858        config_file = host.filesystem.read_text_file("/mock/output_dir/lighttpd.conf")
    5959        self.assertEqual(re.findall(r"alias.url.+", config_file), [
    60             'alias.url = ( "/js-test-resources" => "/test.checkout/LayoutTests/fast/js/resources" )',
     60            'alias.url = ( "/js-test-resources" => "/test.checkout/LayoutTests/resources" )',
    6161            'alias.url += ( "/mock/one-additional-dir" => "/mock-checkout/one-additional-dir" )',
    6262            'alias.url += ( "/mock/another-additional-dir" => "/mock-checkout/one-additional-dir" )',

  • trunk/Tools/Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py

    r155404 r155411  
    4545    include_mapping = {
    4646        "js-test-style.css": "../../js/resources",
    47         "js-test-pre.js": "../../js/resources",
    48         "js-test-post.js": "../../js/resources",
     47        "js-test-pre.js": "../../../resources",
     48        "js-test-post.js": "../../../resources",
    4949        "desktop-gl-constants.js": "resources",
    5050    }

  • trunk/Tools/Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py

    r155404 r155411  
    6868        # Mappings to None are unchanged
    6969        styles = {
    70             "../resources/js-test-style.css": "../../js/resources/js-test-style.css",
    7170            "fail.css": None,
    7271            "resources/stylesheet.css": None,
    … …  
    7473        }
    7574        scripts = {
    76             "../resources/js-test-pre.js": "../../js/resources/js-test-pre.js",
    77             "../resources/js-test-post.js": "../../js/resources/js-test-post.js",
     75            "../resources/js-test-pre.js": "../../../resources/js-test-pre.js",
     76            "../resources/js-test-post.js": "../../../resources/js-test-post.js",
    7877            "../resources/desktop-gl-constants.js": "resources/desktop-gl-constants.js",
    7978
Note: See TracChangeset for help on using the changeset viewer.