Changeset 155447 in webkit


Ignore:
Timestamp:
Sep 10, 2013 9:02:43 AM (11 years ago)
Author:
allan.jensen@digia.com
Message:

REGRESSION (r147454): Youtube annotation links to new window broken
https://bugs.webkit.org/show_bug.cgi?id=114242

Reviewed by Anders Carlsson.

Set the UserGestureIndicator to allow popups the same way the issue was solved for WebKit2.

  • plugins/PluginView.cpp:

(WebCore::PluginView::performRequest):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r155435 r155447  
     12013-09-10  Allan Sandfeld Jensen  <allan.jensen@digia.com>
     2
     3        REGRESSION (r147454): Youtube annotation links to new window broken
     4        https://bugs.webkit.org/show_bug.cgi?id=114242
     5
     6        Reviewed by Anders Carlsson.
     7
     8        Set the UserGestureIndicator to allow popups the same way the issue was solved for WebKit2.
     9
     10        * plugins/PluginView.cpp:
     11        (WebCore::PluginView::performRequest):
     12
    1132013-09-10  Alberto Garcia  <berto@igalia.com>
    214
  • trunk/Source/WebCore/plugins/PluginView.cpp

    r155358 r155447  
    6565#include "SecurityOrigin.h"
    6666#include "Settings.h"
     67#include "UserGestureIndicator.h"
    6768#include "WheelEvent.h"
    6869#include "c_instance.h"
     
    428429    KURL requestURL = request->frameLoadRequest().resourceRequest().url();
    429430    String jsString = scriptStringIfJavaScriptURL(requestURL);
     431
     432    UserGestureIndicator gestureIndicator(request->shouldAllowPopups() ? DefinitelyProcessingUserGesture : PossiblyProcessingUserGesture);
    430433
    431434    if (jsString.isNull()) {
Note: See TracChangeset for help on using the changeset viewer.