Changeset 155533 in webkit


Ignore:
Timestamp:
Sep 11, 2013 9:15:33 AM (11 years ago)
Author:
berto@igalia.com
Message:

[WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns null
https://bugs.webkit.org/show_bug.cgi?id=120892

Reviewed by Martin Robinson.

If the GL context cannot be created then m_isValid is set to false
during the initialization of LayerTreeHostGtk.

This is not really necessary since the rest of the code already
deals with that situation, so it doesn't have any effect other
than breaking the assertion in invalidate().

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r155532 r155533  
     12013-09-11  Alberto Garcia  <berto@igalia.com>
     2
     3        [WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns null
     4        https://bugs.webkit.org/show_bug.cgi?id=120892
     5
     6        Reviewed by Martin Robinson.
     7
     8        If the GL context cannot be created then m_isValid is set to false
     9        during the initialization of LayerTreeHostGtk.
     10
     11        This is not really necessary since the rest of the code already
     12        deals with that situation, so it doesn't have any effect other
     13        than breaking the assertion in invalidate().
     14
     15        * WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
     16        (WebKit::LayerTreeHostGtk::initialize):
     17
    1182013-09-11  Commit Queue  <commit-queue@webkit.org>
    219
  • trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp

    r154658 r155533  
    117117
    118118    GLContext* context = glContext();
    119     if (!context) {
    120         m_isValid = false;
    121         return;
    122     }
     119    if (!context)
     120        return;
    123121
    124122    // The creation of the TextureMapper needs an active OpenGL context.
Note: See TracChangeset for help on using the changeset viewer.