Changeset 155646 in webkit


Ignore:
Timestamp:
Sep 12, 2013 1:42:44 PM (11 years ago)
Author:
ap@apple.com
Message:

Flaky Test: plugins/mouse-events.html
​https://bugs.webkit.org/show_bug.cgi?id=116665

Reviewed by Anders Carlsson.

  • plugins/mouse-events-expected.txt:
  • plugins/mouse-events.html:

This test used async calls for events, and then usually logged responses while waiting
for a plg.eventLoggingEnabled setter synchronously. Depending on sync/async event
order is not reliable, especially with old WebKit1 plug-in IPC code.

  • platform/mac-wk2/plugins/mouse-events-expected.txt: For some unclear reason,

focus works differently in WebKit2.

  • platform/gtk/plugins/mouse-events-expected.txt: Removed.
  • platform/qt/plugins/mouse-events-expected.txt: Removed.
  • platform/win/plugins/mouse-events-expected.txt: Removed.

These results looked similar to new cross-platform ones, hopefully custom results
won't be needed any more.

Location:
trunk/LayoutTests
Files:
3 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r155624 r155646  
     12013-09-12  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Flaky Test: plugins/mouse-events.html
     4        https://bugs.webkit.org/show_bug.cgi?id=116665
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * plugins/mouse-events-expected.txt:
     9        * plugins/mouse-events.html:
     10        This test used async calls for events, and then usually logged responses while waiting
     11        for a plg.eventLoggingEnabled setter synchronously. Depending on sync/async event
     12        order is not reliable, especially with old WebKit1 plug-in IPC code.
     13
     14        * platform/mac-wk2/plugins/mouse-events-expected.txt: For some unclear reason,
     15        focus works differently in WebKit2.
     16
     17        * platform/gtk/plugins/mouse-events-expected.txt: Removed.
     18        * platform/qt/plugins/mouse-events-expected.txt: Removed.
     19        * platform/win/plugins/mouse-events-expected.txt: Removed.
     20        These results looked similar to new cross-platform ones, hopefully custom results
     21        won't be needed any more.
     22
    1232013-09-12  Gurpreet Kaur  <k.gurpreet@samsung.com>
    224

  • trunk/LayoutTests/platform/mac-wk2/plugins/mouse-events-expected.txt

    r111045 r155646  
    1 CONSOLE MESSAGE: PLUGIN: mouseDown at (12, 12)
    2 CONSOLE MESSAGE: PLUGIN: mouseUp at (12, 12)
    3 CONSOLE MESSAGE: PLUGIN: mouseDown at (22, 22)
    4 CONSOLE MESSAGE: PLUGIN: mouseUp at (32, 22)
    51
    62Test for bug 11517: Flash clicks/interactivity not working properly.
     3
     4PLUGIN: mouseDown at (12, 12)
     5PLUGIN: mouseUp at (12, 12)
     6PLUGIN: mouseDown at (22, 22)
     7PLUGIN: mouseUp at (32, 22)
     8PLUGIN: getFocusEvent
     9PASS successfullyParsed is true
     10
     11TEST COMPLETE
     12

  • trunk/LayoutTests/plugins/mouse-events-expected.txt

    r150558 r155646  
    1 CONSOLE MESSAGE: line 27: PLUGIN: getFocusEvent
    2 CONSOLE MESSAGE: line 27: PLUGIN: mouseDown at (12, 12)
    3 CONSOLE MESSAGE: line 27: PLUGIN: mouseUp at (12, 12)
    4 CONSOLE MESSAGE: line 27: PLUGIN: mouseDown at (22, 22)
    5 CONSOLE MESSAGE: line 27: PLUGIN: mouseUp at (32, 22)
    61
    72Test for bug 11517: Flash clicks/interactivity not working properly.
     3
     4PLUGIN: getFocusEvent
     5PLUGIN: mouseDown at (12, 12)
     6PLUGIN: mouseUp at (12, 12)
     7PLUGIN: mouseDown at (22, 22)
     8PLUGIN: mouseUp at (32, 22)
     9PASS successfullyParsed is true
     10
     11TEST COMPLETE
     12

  • trunk/LayoutTests/plugins/mouse-events.html

    r120417 r155646  
    11<html>
     2<head>
     3<script src="../resources/js-test-pre.js"></script>
     4</script>
     5</head>
    26<body>
    37<embed name="plg" type="application/x-webkit-test-netscape" windowedPlugin="false" width=100 height=100></embed>
    48<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=11517">bug 11517</a>:
    59Flash clicks/interactivity not working properly.</p>
     10<div id=console></div>
    611<script>
     12    window.jsTestIsAsync = true;
    713
    814    plg.windowedPlugin = false;
    915    plg.eventLoggingEnabled = true;
    1016
     17    // Our test plug-in logs events through window.console. Override it with a custom
     18    // implementation that counts the number of messages - due to the nature of IPC, it's
     19    // difficult to predict when events get handled.
     20    const expectedMessageCount = 5;
     21    var messageCount = 0;
     22    window.console = {
     23        log: function(message) {
     24            if (messageCount == expectedMessageCount) {
     25                alert("Message unexpectedly leaked from preceding test, plugins/mouse-events.html: " + message);
     26                return;
     27            }
     28
     29            debug(message);
     30
     31            if (++messageCount == expectedMessageCount)
     32                finishJSTest();
     33        }
     34    };
     35
    1136    if (!window.testRunner) {
    12         document.write("This test does not work in manual mode.");
     37        document.write("To test manually, please install WebKit test plug-in, and verify that mouse events get logged.");
    1338    } else {
    14         testRunner.dumpAsText();
    15        
    1639        eventSender.mouseMoveTo(0,0);
    1740        eventSender.mouseMoveTo(20,20);
    … …  
    2447        eventSender.mouseMoveTo(0,0);
    2548    }
    26 
    27     plg.eventLoggingEnabled = false; // stop logging so our output doesn't bleed into the next test
    28 
    2949</script>
     50<script src="../resources/js-test-post.js"></script>
    3051</body>
    3152</html>
Note: See TracChangeset for help on using the changeset viewer.