Changeset 155889 in webkit

Timestamp:

Sep 16, 2013 11:58:46 AM (11 years ago)

Author:

fpizlo@apple.com

Message:

Inlining should work in debug mode (i.e. Executable::newCodeBlock() should call recordParse())
​https://bugs.webkit.org/show_bug.cgi?id=121444

Reviewed by Mark Hahnenberg.

• dfg/DFGArgumentPosition.h: Fix a bug discovered by reenabling inlining. ArgumentPosition may point to the non-canonical VariableAccessData but users of someVariable() want the canonical one.

(JSC::DFG::ArgumentPosition::someVariable):

• runtime/Executable.cpp: Call recordParse() so that the Executable knows things about itself (like if it has captured variables). Otherwise those fields are uninitialized.

(JSC::ScriptExecutable::newCodeBlockFor):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGArgumentPosition.h (modified) (1 diff)
• runtime/Executable.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-09-16  Filip Pizlo  <fpizlo@apple.com>
+
+        Inlining should work in debug mode (i.e. Executable::newCodeBlock() should call recordParse())
+        https://bugs.webkit.org/show_bug.cgi?id=121444
+
+        Reviewed by Mark Hahnenberg.
+
+        * dfg/DFGArgumentPosition.h: Fix a bug discovered by reenabling inlining. ArgumentPosition may point to the non-canonical VariableAccessData but users of someVariable() want the canonical one.
+        (JSC::DFG::ArgumentPosition::someVariable):
+        * runtime/Executable.cpp: Call recordParse() so that the Executable knows things about itself (like if it has captured variables). Otherwise those fields are uninitialized.
+        (JSC::ScriptExecutable::newCodeBlockFor):
+
 2013-09-16  Balazs Kilvady  <kilvadyb@homejinni.com>
 

trunk/Source/JavaScriptCore/dfg/DFGArgumentPosition.h

@@ -53 +53 @@
         if (m_variables.isEmpty())
             return 0;
-        return m_variables[0];
+        return m_variables[0]->find();
     }
     

trunk/Source/JavaScriptCore/runtime/Executable.cpp

@@ -210 +210 @@
         executable->m_unlinkedExecutable->codeBlockFor(
             *vm, executable->m_source, kind, debuggerMode, profilerMode, error);
+    recordParse(executable->m_unlinkedExecutable->features(), executable->m_unlinkedExecutable->hasCapturedVariables(), lineNo(), lastLine(), startColumn()); 
     if (!unlinkedCodeBlock) {
         exception = vm->throwException(