Changeset 15598 in webkit

Timestamp:

Jul 24, 2006 8:58:48 AM (18 years ago)

Author:

ap

Message:

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10009
REGRESSION: Schubert-IT PDF Plug-in not working for full page (works in frames)

No test case possible.

WebCore:

• page/Frame.cpp: (WebCore::Frame::begin): Give PDF plugins a chance to handle frame content, before ImageDocument claims it.

WebKit:

• WebView/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): If we've got a type supported by WebPDFView, make sure to initialize the plugin database, in case a plugin wants to handle it.

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/Frame.cpp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/WebView/WebView.m (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-07-24  Alexey Proskuryakov  <ap@nypop.com>
+
+        Reviewed by Darin.
+
+        Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10009
+        REGRESSION: Schubert-IT PDF Plug-in not working for full page (works in frames)
+
+        * page/Frame.cpp:
+        (WebCore::Frame::begin): Give PDF plugins a chance to handle frame content, before ImageDocument
+        claims it.
+
 2006-07-24  Mitz Pettel  <opendarwin.org@mitzpettel.com>
 

trunk/WebCore/page/Frame.cpp

@@ -589 +589 @@
   else if (DOMImplementation::isTextMIMEType(d->m_request.m_responseMIMEType))
     d->m_doc = new TextDocument(DOMImplementation::instance(), d->m_view.get());
+  else if ((d->m_request.m_responseMIMEType == "application/pdf" || d->m_request.m_responseMIMEType == "text/pdf") && PlugInInfoStore::supportsMIMEType(d->m_request.m_responseMIMEType))
+    d->m_doc = new PluginDocument(DOMImplementation::instance(), d->m_view.get());
   else if (Image::supportsType(d->m_request.m_responseMIMEType))
     d->m_doc = new ImageDocument(DOMImplementation::instance(), d->m_view.get());

trunk/WebKit/ChangeLog

@@ +1 @@
+2006-07-24  Alexey Proskuryakov  <ap@nypop.com>
+
+        Reviewed by Darin.
+
+        Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10009
+        REGRESSION: Schubert-IT PDF Plug-in not working for full page (works in frames)
+
+        * WebView/WebView.m:
+        (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): If we've got a type supported by WebPDFView,
+        make sure to initialize the plugin database, in case a plugin wants to handle it.
+
 2006-07-23  Mark Rowe  <opendarwin.org@bdash.net.nz>
 

trunk/WebKit/WebView/WebView.m

@@ -75 +75 @@
 #import "WebNSViewExtras.h"
 #import "WebPageBridge.h"
+#import "WebPDFView.h"
 #import "WebPluginDatabase.h"
 #import "WebPolicyDelegate.h"
@@ -529 +530 @@
     Class repClass = [[WebDataSource _repTypesAllowImageTypeOmission:YES] _webkit_objectForMIMEType:MIMEType];
     
-    if (!viewClass || !repClass) {
+    if (!viewClass || !repClass || [[WebPDFView supportedMIMETypes] containsObject:MIMEType]) {
         // Our optimization to avoid loading the plug-in DB and image types for the HTML case failed.
         // Load the plug-in DB allowing plug-ins to install types.