Changeset 156383 in webkit


Ignore:
Timestamp:
Sep 24, 2013 10:22:59 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r156379.
http://trac.webkit.org/changeset/156379
https://bugs.webkit.org/show_bug.cgi?id=121894

Caused many assertion failures (Requested by ap on #webkit).

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):

  • css/TransformFunctions.cpp:

(WebCore::transformsForValue):

  • css/WebKitCSSArrayFunctionValue.h:
  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSMatFunctionValue.h:
  • css/WebKitCSSMixFunctionValue.h:
  • css/WebKitCSSSVGDocumentValue.h:
  • css/WebKitCSSShaderValue.h:

(WebCore::toWebKitCSSShaderValue):

  • css/WebKitCSSTransformValue.h:
Location:
trunk/Source/WebCore
Files:
11 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r156382 r156383  
     12013-09-24  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r156379.
     4        http://trac.webkit.org/changeset/156379
     5        https://bugs.webkit.org/show_bug.cgi?id=121894
     6
     7        Caused many assertion failures (Requested by ap on #webkit).
     8
     9        * css/CSSValue.cpp:
     10        (WebCore::CSSValue::destroy):
     11        * css/StyleResolver.cpp:
     12        (WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
     13        (WebCore::StyleResolver::createFilterOperations):
     14        * css/TransformFunctions.cpp:
     15        (WebCore::transformsForValue):
     16        * css/WebKitCSSArrayFunctionValue.h:
     17        * css/WebKitCSSFilterValue.h:
     18        * css/WebKitCSSMatFunctionValue.h:
     19        * css/WebKitCSSMixFunctionValue.h:
     20        * css/WebKitCSSSVGDocumentValue.h:
     21        * css/WebKitCSSShaderValue.h:
     22        (WebCore::toWebKitCSSShaderValue):
     23        * css/WebKitCSSTransformValue.h:
     24
    1252013-09-24  Ryosuke Niwa  <rniwa@webkit.org>
    226
  • trunk/Source/WebCore/css/CSSValue.cpp

    r156379 r156383  
    447447        return;
    448448    case WebKitCSSTransformClass:
    449         delete toWebKitCSSTransformValue(this);
     449        delete static_cast<WebKitCSSTransformValue*>(this);
    450450        return;
    451451    case LineBoxContainClass:
     
    465465        return;
    466466    case WebKitCSSFilterClass:
    467         delete toWebKitCSSFilterValue(this);
     467        delete static_cast<WebKitCSSFilterValue*>(this);
    468468        return;
    469469#if ENABLE(CSS_SHADERS)
    470470    case WebKitCSSArrayFunctionValueClass:
    471         delete toWebKitCSSArrayFunctionValue(this);
     471        delete static_cast<WebKitCSSArrayFunctionValue*>(this);
    472472        return;
    473473    case WebKitCSSMatFunctionValueClass:
    474         delete toWebKitCSSMatFunctionValue(this);
     474        delete static_cast<WebKitCSSMatFunctionValue*>(this);
    475475        return;
    476476    case WebKitCSSMixFunctionValueClass:
    477         delete toWebKitCSSMixFunctionValue(this);
     477        delete static_cast<WebKitCSSMixFunctionValue*>(this);
    478478        return;
    479479    case WebKitCSSShaderClass:
     
    495495        return;
    496496    case WebKitCSSSVGDocumentClass:
    497         delete toWebKitCSSSVGDocumentValue(this);
     497        delete static_cast<WebKitCSSSVGDocumentValue*>(this);
    498498        return;
    499499#endif
  • trunk/Source/WebCore/css/StyleResolver.cpp

    r156379 r156383  
    36323632        CSSValue* fragmentShaderOrMixFunction = shadersList->itemWithoutBoundsCheck(1);
    36333633        if (fragmentShaderOrMixFunction->isWebKitCSSMixFunctionValue()) {
    3634             WebKitCSSMixFunctionValue* mixFunction = toWebKitCSSMixFunctionValue(fragmentShaderOrMixFunction);
     3634            WebKitCSSMixFunctionValue* mixFunction = static_cast<WebKitCSSMixFunctionValue*>(fragmentShaderOrMixFunction);
    36353635            CSSValueListIterator iterator(mixFunction);
    36363636
     
    37533753            continue;
    37543754
    3755         WebKitCSSFilterValue* filterValue = toWebKitCSSFilterValue(i.value());
     3755        WebKitCSSFilterValue* filterValue = static_cast<WebKitCSSFilterValue*>(i.value());
    37563756        FilterOperation::OperationType operationType = filterOperationForType(filterValue->operationType());
    37573757
     
    37803780                continue;
    37813781
    3782             WebKitCSSSVGDocumentValue* svgDocumentValue = toWebKitCSSSVGDocumentValue(argument);
     3782            WebKitCSSSVGDocumentValue* svgDocumentValue = static_cast<WebKitCSSSVGDocumentValue*>(argument);
    37833783            KURL url = m_state.document().completeURL(svgDocumentValue->url());
    37843784
  • trunk/Source/WebCore/css/TransformFunctions.cpp

    r156379 r156383  
    9797            continue;
    9898
    99         WebKitCSSTransformValue* transformValue = toWebKitCSSTransformValue(i.value());
     99        WebKitCSSTransformValue* transformValue = static_cast<WebKitCSSTransformValue*>(i.value());
    100100        if (!transformValue->length())
    101101            continue;
  • trunk/Source/WebCore/css/WebKitCSSArrayFunctionValue.h

    r156379 r156383  
    5656};
    5757
    58 inline WebKitCSSArrayFunctionValue* toWebKitCSSArrayFunctionValue(CSSValue* value)
    59 {
    60     ASSERT_WITH_SECURITY_IMPLICATION(!value || value->isWebKitCSSArrayFunctionValue());
    61     return static_cast<WebKitCSSArrayFunctionValue*>(value);
    62 }
    63 
    6458} // namespace WebCore
    6559
  • trunk/Source/WebCore/css/WebKitCSSFilterValue.h

    r156379 r156383  
    7878};
    7979
    80 inline WebKitCSSFilterValue* toWebKitCSSFilterValue(CSSValue* value)
    81 {
    82     ASSERT_WITH_SECURITY_IMPLICATION(!value || value->isWebKitCSSFilterValue());
    83     return static_cast<WebKitCSSFilterValue*>(value);
    84 }
    85 
    8680}
    8781
  • trunk/Source/WebCore/css/WebKitCSSMatFunctionValue.h

    r156379 r156383  
    5656};
    5757
    58 inline WebKitCSSMatFunctionValue* toWebKitCSSMatFunctionValue(CSSValue* value)
    59 {
    60     ASSERT_WITH_SECURITY_IMPLICATION(!value || value->isWebKitCSSMatFunctionValue());
    61     return static_cast<WebKitCSSMatFunctionValue*>(value);
    62 }
    63 
    6458} // namespace WebCore
    6559
  • trunk/Source/WebCore/css/WebKitCSSMixFunctionValue.h

    r156379 r156383  
    5555    WebKitCSSMixFunctionValue(const WebKitCSSMixFunctionValue& cloneFrom);
    5656};
    57 
    58 inline WebKitCSSMixFunctionValue* toWebKitCSSMixFunctionValue(CSSValue* value)
    59 {
    60     ASSERT_WITH_SECURITY_IMPLICATION(!value || value->isWebKitCSSMixFunctionValue());
    61     return static_cast<WebKitCSSMixFunctionValue*>(value);
    62 }
    6357   
    6458} // namespace WebCore
  • trunk/Source/WebCore/css/WebKitCSSSVGDocumentValue.h

    r156379 r156383  
    5555};
    5656
    57 inline WebKitCSSSVGDocumentValue* toWebKitCSSSVGDocumentValue(CSSValue* value)
    58 {
    59     ASSERT_WITH_SECURITY_IMPLICATION(!value || value->isWebKitCSSSVGDocumentValue());
    60     return static_cast<WebKitCSSSVGDocumentValue*>(value);
    61 }
    62 
    6357} // namespace WebCore
    6458
  • trunk/Source/WebCore/css/WebKitCSSShaderValue.h

    r156379 r156383  
    7272inline WebKitCSSShaderValue* toWebKitCSSShaderValue(CSSValue* value)
    7373{
    74     ASSERT_WITH_SECURITY_IMPLICATION(!value || value->isWebKitCSSShaderValue());
    7574    return value->isWebKitCSSShaderValue() ? static_cast<WebKitCSSShaderValue*>(value) : 0;
    7675}
  • trunk/Source/WebCore/css/WebKitCSSTransformValue.h

    r156379 r156383  
    8383};
    8484
    85 inline WebKitCSSTransformValue* toWebKitCSSTransformValue(CSSValue* value)
    86 {
    87     ASSERT_WITH_SECURITY_IMPLICATION(!value || value->isWebKitCSSTransformValue());
    88     return static_cast<WebKitCSSTransformValue*>(value);
    89 }
    90 
    9185}
    9286
Note: See TracChangeset for help on using the changeset viewer.