Changeset 156606 in webkit

Timestamp:

Sep 28, 2013 9:14:00 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

filter: drop-shadow doesnot support viewport units
​https://bugs.webkit.org/show_bug.cgi?id=122053

Patch by Gurpreet Kaur <​k.gurpreet@samsung.com> on 2013-09-28
Reviewed by Darin Adler.

Source/WebCore:

drop-shadow properties were not applied incase its values
were given in vh, vw, vmax, vmin units.

Tests: fast/css/drop-shadow-viewport-height.html

fast/css/drop-shadow-viewport-vmax.html
fast/css/drop-shadow-viewport-vmin.html
fast/css/drop-shadow-viewport-width.html

• css/StyleResolver.cpp:

(WebCore::StyleResolver::createFilterOperations):
Calculating the drop-shadow values which has been specified in viewport
units.The vh/vw units are calcultated as percent of viewport height and
viewport width respectively. 1vmax: 1vw or 1vh, whatever is largest.
1vmin: 1vw or 1vh, whatever is smallest.

LayoutTests:

• fast/css/drop-shadow-viewport-height-expected-mismatch.html: Added.
• fast/css/drop-shadow-viewport-height.html: Added.
• fast/css/drop-shadow-viewport-vmax-expected-mismatch.html: Added.
• fast/css/drop-shadow-viewport-vmax.html: Added.
• fast/css/drop-shadow-viewport-vmin-expected-mismatch.html: Added.
• fast/css/drop-shadow-viewport-vmin.html: Added.
• fast/css/drop-shadow-viewport-width-expected-mismatch.html: Added.
• fast/css/drop-shadow-viewport-width.html: Added.

Added new tests for verifying that drop-shadow properties are applied
when its values are viewport units.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/drop-shadow-viewport-height-expected-mismatch.html (added)
• LayoutTests/fast/css/drop-shadow-viewport-height.html (added)
• LayoutTests/fast/css/drop-shadow-viewport-vmax-expected-mismatch.html (added)
• LayoutTests/fast/css/drop-shadow-viewport-vmax.html (added)
• LayoutTests/fast/css/drop-shadow-viewport-vmin-expected-mismatch.html (added)
• LayoutTests/fast/css/drop-shadow-viewport-vmin.html (added)
• LayoutTests/fast/css/drop-shadow-viewport-width-expected-mismatch.html (added)
• LayoutTests/fast/css/drop-shadow-viewport-width.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/StyleResolver.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-09-28  Gurpreet Kaur  <k.gurpreet@samsung.com>
+
+        filter: drop-shadow doesnot support viewport units
+        https://bugs.webkit.org/show_bug.cgi?id=122053
+
+        Reviewed by Darin Adler.
+
+        * fast/css/drop-shadow-viewport-height-expected-mismatch.html: Added.
+        * fast/css/drop-shadow-viewport-height.html: Added.
+        * fast/css/drop-shadow-viewport-vmax-expected-mismatch.html: Added.
+        * fast/css/drop-shadow-viewport-vmax.html: Added.
+        * fast/css/drop-shadow-viewport-vmin-expected-mismatch.html: Added.
+        * fast/css/drop-shadow-viewport-vmin.html: Added.
+        * fast/css/drop-shadow-viewport-width-expected-mismatch.html: Added.
+        * fast/css/drop-shadow-viewport-width.html: Added.
+        Added new tests for verifying that drop-shadow properties are applied
+        when its values are viewport units.
+
 2013-09-28  Gurpreet Kaur  <k.gurpreet@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-09-28  Gurpreet Kaur  <k.gurpreet@samsung.com>
+
+        filter: drop-shadow doesnot support viewport units
+        https://bugs.webkit.org/show_bug.cgi?id=122053
+
+        Reviewed by Darin Adler.
+
+        drop-shadow properties were not applied incase its values
+        were given in vh, vw, vmax, vmin units.
+
+        Tests: fast/css/drop-shadow-viewport-height.html
+               fast/css/drop-shadow-viewport-vmax.html
+               fast/css/drop-shadow-viewport-vmin.html
+               fast/css/drop-shadow-viewport-width.html
+
+        * css/StyleResolver.cpp:
+        (WebCore::StyleResolver::createFilterOperations):
+        Calculating the drop-shadow values which has been specified in viewport
+        units.The vh/vw units are calcultated as percent of viewport height and
+        viewport width respectively. 1vmax: 1vw or 1vh, whatever is largest.
+        1vmin: 1vw or 1vh, whatever is smallest.
+
 2013-09-28  Gurpreet Kaur  <k.gurpreet@samsung.com>
 

trunk/Source/WebCore/css/StyleResolver.cpp

@@ -3873 +3873 @@
 
             ShadowValue* item = static_cast<ShadowValue*>(cssValue);
-            IntPoint location(item->x->computeLength<int>(style, rootStyle, zoomFactor),
-                              item->y->computeLength<int>(style, rootStyle, zoomFactor));
+            int x = item->x->computeLength<int>(style, rootStyle, zoomFactor);
+            if (item->x->isViewportPercentageLength())
+                x = viewportPercentageValue(*item->x, x);
+            int y = item->y->computeLength<int>(style, rootStyle, zoomFactor);
+            if (item->y->isViewportPercentageLength())
+                y = viewportPercentageValue(*item->y, y);
+            IntPoint location(x, y);
             int blur = item->blur ? item->blur->computeLength<int>(style, rootStyle, zoomFactor) : 0;
+            if (item->blur && item->blur->isViewportPercentageLength())
+                blur = viewportPercentageValue(*item->blur, blur);
             Color color;
             if (item->color)