Changeset 156682 in webkit

Timestamp:

Sep 30, 2013 2:56:02 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
​https://bugs.webkit.org/show_bug.cgi?id=122032

Patch by Drew Yao <​ayao@apple.com> on 2013-09-30
Reviewed by Andreas Kling.

Convert assertion to ASSERT_WITH_SECURITY_IMPLICATION to help catch use after free bugs.

No new tests needed.

• rendering/InlineBox.h:

(WebCore::InlineBox::parent):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/InlineBox.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-09-30  Drew Yao  <ayao@apple.com>
+
+        ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
+        https://bugs.webkit.org/show_bug.cgi?id=122032
+
+        Reviewed by Andreas Kling.
+
+        Convert assertion to ASSERT_WITH_SECURITY_IMPLICATION to help catch use after free bugs.
+
+        No new tests needed.
+
+        * rendering/InlineBox.h:
+        (WebCore::InlineBox::parent):
+
 2013-09-30  Yongjun Zhang  <yongjun_zhang@apple.com>
 

trunk/Source/WebCore/rendering/InlineBox.h

@@ -186 +186 @@
     InlineFlowBox* parent() const
     {
-        ASSERT(!m_hasBadParent);
+        ASSERT_WITH_SECURITY_IMPLICATION(!m_hasBadParent);
         return m_parent;
     }