Changeset 156710 in webkit


Ignore:
Timestamp:
Oct 1, 2013 7:58:32 AM (10 years ago)
Author:
allan.jensen@digia.com
Message:

[Texmap] CSS filter not working on software composited layers
https://bugs.webkit.org/show_bug.cgi?id=122159

Reviewed by Noam Rosenthal.

Tell the rendering layer we do not support CSS filters when we do not. This
will make RenderLayer fall back to using its own software implementation.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setFilters):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r156709 r156710  
     12013-10-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
     2
     3        [Texmap] CSS filter not working on software composited layers
     4        https://bugs.webkit.org/show_bug.cgi?id=122159
     5
     6        Reviewed by Noam Rosenthal.
     7
     8        Tell the rendering layer we do not support CSS filters when we do not. This
     9        will make RenderLayer fall back to using its own software implementation.
     10
     11        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
     12        (WebCore::GraphicsLayerTextureMapper::setFilters):
     13        * platform/graphics/texmap/TextureMapperImageBuffer.cpp:
     14        (WebCore::BitmapTextureImageBuffer::applyFilters):
     15
    1162013-10-01  Darin Adler  <darin@apple.com>
    217
  • trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp

    r156560 r156710  
    671671bool GraphicsLayerTextureMapper::setFilters(const FilterOperations& filters)
    672672{
     673    TextureMapper* textureMapper = m_layer->textureMapper();
     674    // TextureMapperImageBuffer does not support CSS filters.
     675    if (!textureMapper || textureMapper->accelerationMode() == TextureMapper::SoftwareMode)
     676        return false;
    673677    notifyChange(FilterChange);
    674678    return GraphicsLayer::setFilters(filters);
  • trunk/Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp

    r154375 r156710  
    166166PassRefPtr<BitmapTexture> BitmapTextureImageBuffer::applyFilters(TextureMapper*, const FilterOperations&)
    167167{
     168    ASSERT_NOT_REACHED();
    168169    return this;
    169170}
Note: See TracChangeset for help on using the changeset viewer.