Changeset 156850 in webkit


Ignore:
Timestamp:
Oct 3, 2013 12:53:13 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[CSS Regions] Follow-up code style change after bug #121828 All regions have layers
​https://bugs.webkit.org/show_bug.cgi?id=122265

Patch by Mihai Maerean <Mihai Maerean> on 2013-10-03
Reviewed by Darin Adler.

Comments moved to the cpp file, as requested in the review of bug #121828 All regions have layers.

No new tests, no behavior change.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::requiresLayer):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::requiresLayer):

  • rendering/RenderRegion.h:
Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r156848 r156850  
     12013-10-03  Mihai Maerean  <mmaerean@adobe.com>
     2
     3        [CSS Regions] Follow-up code style change after bug #121828 All regions have layers
     4        https://bugs.webkit.org/show_bug.cgi?id=122265
     5
     6        Reviewed by Darin Adler.
     7
     8        Comments moved to the cpp file, as requested in the review of bug #121828 All regions have layers.
     9
     10        No new tests, no behavior change.
     11
     12        * rendering/RenderMultiColumnSet.cpp:
     13        (WebCore::RenderMultiColumnSet::requiresLayer):
     14        * rendering/RenderMultiColumnSet.h:
     15        * rendering/RenderRegion.cpp:
     16        (WebCore::RenderRegion::requiresLayer):
     17        * rendering/RenderRegion.h:
     18
    1192013-10-03  Alejandro G. Castro  <alex@igalia.com>
    220

  • trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp

    r156478 r156850  
    412412}
    413413
     414bool RenderMultiColumnSet::requiresLayer() const
     415{
     416    // RenderMultiColumnSet derives from RenderRegion, but unlike the CSS Regions specification, the Multi-Columns CSS
     417    // specification states that the column boxes do not establish new Stacking Contexts.
     418    return RenderBlockFlow::requiresLayer();
     419}
     420
    414421void RenderMultiColumnSet::collectLayerFragments(LayerFragments& fragments, const LayoutRect& layerBoundingBox, const LayoutRect& dirtyRect)
    415422{

  • trunk/Source/WebCore/rendering/RenderMultiColumnSet.h

    r156767 r156850  
    119119    virtual void repaintFlowThreadContent(const LayoutRect& repaintRect, bool immediate) const OVERRIDE;
    120120
    121     // RenderMultiColumnSet derives from RenderRegion, but unlike the CSS Regions specification, the Multi-Columns CSS
    122     // specification states that the column boxes do not establish new Stacking Contexts.
    123     virtual bool requiresLayer() const OVERRIDE FINAL { return RenderBlockFlow::requiresLayer(); }
     121    virtual bool requiresLayer() const OVERRIDE;
    124122
    125123    virtual void collectLayerFragments(LayerFragments&, const LayoutRect& layerBoundingBox, const LayoutRect& dirtyRect) OVERRIDE;

  • trunk/Source/WebCore/rendering/RenderRegion.cpp

    r156767 r156850  
    375375}
    376376
     377bool RenderRegion::requiresLayer() const
     378{
     379    // All regions create stacking contexts, as specified in the CSS standard. Do that by allocating a separate RenderLayer for each.
     380    return true;
     381}
     382
    377383void RenderRegion::installFlowThread()
    378384{

  • trunk/Source/WebCore/rendering/RenderRegion.h

    r156767 r156850  
    140140    virtual void collectLayerFragments(LayerFragments&, const LayoutRect&, const LayoutRect&) { }
    141141
    142     // All regions create stacking contexts, as specified in the CSS standard. Do that by allocating a separate RenderLayer for each.
    143     virtual bool requiresLayer() const OVERRIDE { return true; }
     142    virtual bool requiresLayer() const OVERRIDE;
    144143
    145144    void addLayoutOverflowForBox(const RenderBox*, const LayoutRect&);
Note: See TracChangeset for help on using the changeset viewer.