Changeset 156931 in webkit

Timestamp:

Oct 4, 2013 5:26:12 PM (11 years ago)

Author:

mikhail.pozdnyakov@intel.com

Message:

Remove WTF smart pointers 'const_pointer_cast'
​https://bugs.webkit.org/show_bug.cgi?id=122325

Reviewed by Darin Adler.

Removed WTF smart pointers 'const_pointer_cast' functions as:

• they were not used
• their implementation was wrong as they tried to cast to a different pointer type

• wtf/PassOwnPtr.h:
• wtf/PassRefPtr.h:
• wtf/RefPtr.h:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/PassOwnPtr.h (modified) (2 diffs)
• wtf/PassRefPtr.h (modified) (2 diffs)
• wtf/RefPtr.h (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-10-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        Remove WTF smart pointers 'const_pointer_cast'
+        https://bugs.webkit.org/show_bug.cgi?id=122325
+
+        Reviewed by Darin Adler.
+
+        Removed WTF smart pointers 'const_pointer_cast' functions as:
+        - they were not used
+        - their implementation was wrong as they tried to cast to a different pointer type
+
+        * wtf/PassOwnPtr.h:
+        * wtf/PassRefPtr.h:
+        * wtf/RefPtr.h:
+
 2013-10-04  Oliver Hunt  <oliver@apple.com>
 

trunk/Source/WTF/wtf/PassOwnPtr.h

@@ -157 +157 @@
     }
 
-    template<typename T, typename U> inline PassOwnPtr<T> const_pointer_cast(const PassOwnPtr<U>& p) 
-    {
-        return adoptPtr(const_cast<T*>(p.leakPtr()));
-    }
-
     template<typename T> inline T* getPtr(const PassOwnPtr<T>& p)
     {
@@ -171 +166 @@
 using WTF::PassOwnPtr;
 using WTF::adoptPtr;
-using WTF::const_pointer_cast;
 using WTF::static_pointer_cast;
 

trunk/Source/WTF/wtf/PassRefPtr.h

@@ -158 +158 @@
     }
 
-    template<typename T, typename U> inline PassRefPtr<T> const_pointer_cast(const PassRefPtr<U>& p) 
-    { 
-        return adoptRef(const_cast<T*>(p.leakRef())); 
-    }
-
     template<typename T> inline T* getPtr(const PassRefPtr<T>& p)
     {
@@ -173 +168 @@
 using WTF::adoptRef;
 using WTF::static_pointer_cast;
-using WTF::const_pointer_cast;
 
 #endif // WTF_PassRefPtr_h

trunk/Source/WTF/wtf/RefPtr.h

@@ -201 +201 @@
     }
 
-    template<typename T, typename U> inline RefPtr<T> const_pointer_cast(const RefPtr<U>& p)
-    { 
-        return RefPtr<T>(const_cast<T*>(p.get())); 
-    }
-
     template<typename T> inline T* getPtr(const RefPtr<T>& p)
     {
@@ -215 +210 @@
 using WTF::RefPtr;
 using WTF::static_pointer_cast;
-using WTF::const_pointer_cast;
 
 #endif // WTF_RefPtr_h