Changeset 157280 in webkit

Timestamp:

Oct 10, 2013 5:40:55 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Making the base implementation of isAudioStreamSource, in MediaStreamSource, return the correct value
​https://bugs.webkit.org/show_bug.cgi?id=122612

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-10-10
Reviewed by Jer Noble.

There is no reason for this implementation, in the base class, to always return false
if we already have the information about the type of the source.

No new tests needed.

• Modules/webaudio/MediaStreamAudioSource.h:
• platform/mediastream/MediaStreamSource.h:

(WebCore::MediaStreamSource::isAudioStreamSource):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webaudio/MediaStreamAudioSource.h (modified) (1 diff)
• platform/mediastream/MediaStreamSource.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-10-10  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
+
+        Making the base implementation of isAudioStreamSource, in MediaStreamSource, return the correct value
+        https://bugs.webkit.org/show_bug.cgi?id=122612
+
+        Reviewed by Jer Noble.
+
+        There is no reason for this implementation, in the base class, to always return false
+        if we already have the information about the type of the source.
+
+        No new tests needed.
+
+        * Modules/webaudio/MediaStreamAudioSource.h:
+        * platform/mediastream/MediaStreamSource.h:
+        (WebCore::MediaStreamSource::isAudioStreamSource):
+
 2013-10-10  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.h

@@ -46 +46 @@
     ~MediaStreamAudioSource() { }
 
-    virtual bool isAudioStreamSource() const { return true; }
     virtual bool useIDForTrackID() const { return true; }
 

trunk/Source/WebCore/platform/mediastream/MediaStreamSource.h

@@ -66 +66 @@
     virtual ~MediaStreamSource() { }
 
-    virtual bool isAudioStreamSource() const { return false; }
+    bool isAudioStreamSource() const { return type() == Audio; }
     virtual bool useIDForTrackID() const { return false; }