Changeset 157482 in webkit

Timestamp:

Oct 15, 2013 8:59:12 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

FTL: add support for Int52ToValue and fix putByVal of int52s.
​https://bugs.webkit.org/show_bug.cgi?id=122873

Patch by Nadav Rotem <​nrotem@apple.com> on 2013-10-15
Reviewed by Filip Pizlo.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileInt52ToValue):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• ftl/FTLCapabilities.cpp (modified) (1 diff)
• ftl/FTLLowerDFGToLLVM.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-10-15  Nadav Rotem  <nrotem@apple.com>
+
+        FTL: add support for Int52ToValue and fix putByVal of int52s.
+        https://bugs.webkit.org/show_bug.cgi?id=122873
+
+        Reviewed by Filip Pizlo.
+
+        * ftl/FTLCapabilities.cpp:
+        (JSC::FTL::canCompile):
+        * ftl/FTLLowerDFGToLLVM.cpp:
+        (JSC::FTL::LowerDFGToLLVM::compileNode):
+        (JSC::FTL::LowerDFGToLLVM::compileInt52ToValue):
+        (JSC::FTL::LowerDFGToLLVM::compilePutByVal):
+
 2013-10-15  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp

@@ -96 +96 @@
     case PutClosureVar:
     case GetById:
+    case Int52ToValue:
         // These are OK.
         break;

trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp

@@ -450 +450 @@
             compileValueToInt32();
             break;
+        case Int52ToValue:
+            compileInt52ToValue();
+            break;
         default:
             RELEASE_ASSERT_NOT_REACHED();
@@ -472 +475 @@
         setInt32(m_out.zeroExt(lowBoolean(m_node->child1()), m_out.int32));
     }
-    
+
+    void compileInt52ToValue()
+    {
+        setJSValue(lowJSValue(m_node->child1()));
+    }
+
     void compileUpsilon()
     {
@@ -1531 +1539 @@
                     LValue intValue;
                     switch (child3.useKind()) {
+                    case MachineIntUse:
                     case Int32Use: {
-                        intValue = lowInt32(child3);
+                        if (child3.useKind() == Int32Use)
+                            intValue = lowInt32(child3);
+                        else
+                            intValue = m_out.castToInt32(lowInt52(child3));
+
                         if (isClamped(type)) {
                             ASSERT(elementSize(type) == 1);