Changeset 157532 in webkit

Timestamp:

Oct 16, 2013 3:10:23 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Remove useless architecture specific implementation in DFG.
​https://bugs.webkit.org/show_bug.cgi?id=122917.

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-16
Reviewed by Michael Saboff.

With CPU(ARM) && CPU(ARM_HARDFP) architecture, the fallback implementation is fine
as FPRInfo::argumentFPR0 == FPRInfo::returnValueFPR in this case.

• dfg/DFGSpeculativeJIT.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGSpeculativeJIT.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-10-16  Julien Brianceau  <jbriance@cisco.com>
+
+        Remove useless architecture specific implementation in DFG.
+        https://bugs.webkit.org/show_bug.cgi?id=122917.
+
+        Reviewed by Michael Saboff.
+
+        With CPU(ARM) && CPU(ARM_HARDFP) architecture, the fallback implementation is fine
+        as FPRInfo::argumentFPR0 == FPRInfo::returnValueFPR in this case.
+
+        * dfg/DFGSpeculativeJIT.h:
+
 2013-10-16  Julien Brianceau  <jbriance@cisco.com>
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h

@@ -1802 +1802 @@
         return call;
     }
-#elif CPU(ARM)
-#if CPU(ARM_HARDFP)
-    JITCompiler::Call appendCallWithExceptionCheckSetResult(const FunctionPtr& function, FPRReg result)
-    {
-        JITCompiler::Call call = appendCallWithExceptionCheck(function);
-        if (result != InvalidFPRReg)
-            m_jit.moveDouble(FPRInfo::argumentFPR0, result);
-        return call;
-    }
-    JITCompiler::Call appendCallSetResult(const FunctionPtr& function, FPRReg result)
-    {
-        JITCompiler::Call call = appendCall(function);
-        if (result != InvalidFPRReg)
-            m_jit.moveDouble(FPRInfo::argumentFPR0, result);
-        return call;
-    }
-#else
+#elif CPU(ARM) && !CPU(ARM_HARDFP)
     JITCompiler::Call appendCallWithExceptionCheckSetResult(const FunctionPtr& function, FPRReg result)
     {
@@ -1833 +1817 @@
         return call;
     }
-#endif // CPU(ARM_HARDFP)
-#else
+#else // CPU(X86_64) || (CPU(ARM) && CPU(ARM_HARDFP)) || CPU(ARM64) || CPU(MIPS) || CPU(SH4)
     JITCompiler::Call appendCallWithExceptionCheckSetResult(const FunctionPtr& function, FPRReg result)
     {