Changeset 157600 in webkit


Ignore:
Timestamp:
Oct 17, 2013 2:29:33 PM (11 years ago)
Author:
Antoine Quint
Message:

Web Inspector: logged objects are highlighted in blue
​https://bugs.webkit.org/show_bug.cgi?id=122897

Reviewed by Joseph Pecoraro.

Switch to using the system highlight color for the background selected messages.
Also removing SVG assets no longer needed since we won't be showing white prompt
and result icons anymore as well as a few generated canvas states.

  • UserInterface/Images/UserInputPromptPreviousSelected.svg: Removed.
  • UserInterface/Images/UserInputResultSelected.svg: Removed.
  • UserInterface/LogContentView.css:

(.console-messages:focus .console-item.selected):

  • UserInterface/Main.js:

(WebInspector._generateDisclosureTriangleImages):

Location:
trunk/Source/WebInspectorUI
Files:
2 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r157597 r157600  
     12013-10-17  Antoine Quint  <graouts@apple.com>
     2
     3        Web Inspector: logged objects are highlighted in blue
     4        https://bugs.webkit.org/show_bug.cgi?id=122897
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        Switch to using the system highlight color for the background selected messages.
     9        Also removing SVG assets no longer needed since we won't be showing white prompt
     10        and result icons anymore as well as a few generated canvas states.
     11
     12        * UserInterface/Images/UserInputPromptPreviousSelected.svg: Removed.
     13        * UserInterface/Images/UserInputResultSelected.svg: Removed.
     14        * UserInterface/LogContentView.css:
     15        (.console-messages:focus .console-item.selected):
     16        * UserInterface/Main.js:
     17        (WebInspector._generateDisclosureTriangleImages):
     18
    1192013-10-17  Antoine Quint  <graouts@apple.com>
    220

  • trunk/Source/WebInspectorUI/UserInterface/LogContentView.css

    r155241 r157600  
    5858
    5959.console-messages:focus .console-item.selected {
    60     background-color: rgb(56, 121, 217);
    61 }
    62 
    63 .console-messages:focus .console-item.selected * {
    64     color: white !important;
     60    background-color: highlight;
    6561}
    6662
    6763.console-user-command-result.console-log-level::before {
    6864    background-image: url(Images/UserInputResult.svg);
    69 }
    70 
    71 .console-messages:focus .console-item.selected .console-user-command-result.console-log-level::before {
    72     background-image: url(Images/UserInputResultSelected.svg);
    7365}
    7466
    … …  
    135127}
    136128
    137 .console-messages:focus .console-item.selected .console-group-title::before {
    138     background-image: -webkit-canvas(disclosure-triangle-small-open-selected);
    139 }
    140 
    141129.console-group.collapsed .console-group-title::before {
    142130    background-image: -webkit-canvas(disclosure-triangle-small-closed-normal);
    143131}
    144132
    145 .console-messages:focus .console-group.collapsed .console-item.selected .console-group-title::before {
    146     background-image: -webkit-canvas(disclosure-triangle-small-closed-selected);
    147 }
    148 
    149133.console-group.collapsed > .console-group-messages {
    150134    display: none;
    … …  
    161145.console-error-level .console-message-text, .console-error-level .section .header .title {
    162146    color: red !important;
    163 }
    164 
    165 .console-messages:focus .console-item.selected .console-message-text,
    166 .console-messages:focus .console-item.selected .section .header .title {
    167     color: white !important;
    168147}
    169148
    … …  
    193172.console-user-command::before {
    194173    background-image: url(Images/UserInputPromptPrevious.svg);
    195 }
    196 
    197 .console-messages:focus .console-item.selected .console-user-command::before {
    198     background-image: url(Images/UserInputPromptPreviousSelected.svg);
    199174}
    200175
    … …  
    232207    top: 2px;
    233208    left: 1px;
    234 }
    235 
    236 .console-messages:focus .console-item.selected .section .header::before {
    237     background-image: -webkit-canvas(disclosure-triangle-tiny-closed-selected);
    238 }
    239 
    240 .console-messages:focus .console-item.selected .section.expanded .header::before {
    241     background-image: -webkit-canvas(disclosure-triangle-tiny-open-selected);
    242 }
    243 
    244 .console-messages:focus .console-item.selected .properties-tree li.parent::before {
    245     background-image: -webkit-canvas(disclosure-triangle-tiny-closed-selected);
    246 }
    247 
    248 .console-messages:focus .console-item.selected .properties-tree li.parent.expanded::before {
    249     background-image: -webkit-canvas(disclosure-triangle-tiny-open-selected);
    250209}
    251210
    … …  
    403362}
    404363
    405 .outline-disclosure ol:focus li.selected {
    406     color: white;
    407 }
    408 
    409 .outline-disclosure ol.search-match-found li.selected {
    410     color: white;
    411 }
    412 
    413 .outline-disclosure ol:focus li.selected * {
    414     color: inherit;
    415 }
    416 
    417 .outline-disclosure ol.search-match-found li.selected * {
    418     color: inherit;
    419 }
    420 
    421364.outline-disclosure li.parent {
    422365    margin-left: -12px
    … …  
    443386}
    444387
    445 .console-messages:focus .console-item.selected .outline-disclosure li.parent::before {
    446     background-image: -webkit-canvas(disclosure-triangle-tiny-closed-selected);
    447 }
    448 
    449388.outline-disclosure li.parent.expanded::before {
    450389    background-image: -webkit-canvas(disclosure-triangle-tiny-open-normal);
    451 }
    452 
    453 .console-messages:focus .console-item.selected .outline-disclosure li.parent.expanded::before {
    454     background-image: -webkit-canvas(disclosure-triangle-tiny-open-selected);
    455390}
    456391

  • trunk/Source/WebInspectorUI/UserInterface/Main.js

    r157269 r157600  
    14561456    specifications["normal"] = {fillColor: [0, 0, 0, 0.5]};
    14571457    specifications["normal-active"] = {fillColor: [0, 0, 0, 0.7]};
    1458     specifications["selected"] = {fillColor: [255, 255, 255, 0.8]};
    1459     specifications["selected-active"] = {fillColor: [255, 255, 255, 1]};
    14601458
    14611459    generateColoredImagesForCSS("Images/DisclosureTriangleSmallOpen.svg", specifications, 13, 13, "disclosure-triangle-small-open-");
    14621460    generateColoredImagesForCSS("Images/DisclosureTriangleSmallClosed.svg", specifications, 13, 13, "disclosure-triangle-small-closed-");
     1461
     1462    specifications["selected"] = {fillColor: [255, 255, 255, 0.8]};
    14631463
    14641464    generateColoredImagesForCSS("Images/DisclosureTriangleTinyOpen.svg", specifications, 8, 8, "disclosure-triangle-tiny-open-");

  • trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.vcxproj

    r154922 r157600  
    537537    <None Include="..\UserInterface\Images\UserInputPrompt.svg" />
    538538    <None Include="..\UserInterface\Images\UserInputPromptPrevious.svg" />
    539     <None Include="..\UserInterface\Images\UserInputPromptPreviousSelected.svg" />
    540539    <None Include="..\UserInterface\Images\UserInputResult.svg" />
    541     <None Include="..\UserInterface\Images\UserInputResultSelected.svg" />
    542540    <None Include="..\UserInterface\Images\Warning.svg" />
    543541    <None Include="..\UserInterface\Images\Weight.svg" />

  • trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters

    r154922 r157600  
    16961696      <Filter>Images</Filter>
    16971697    </None>
    1698     <None Include="..\UserInterface\Images\UserInputPromptPreviousSelected.svg">
    1699       <Filter>Images</Filter>
    1700     </None>
    17011698    <None Include="..\UserInterface\Images\UserInputResult.svg">
    1702       <Filter>Images</Filter>
    1703     </None>
    1704     <None Include="..\UserInterface\Images\UserInputResultSelected.svg">
    17051699      <Filter>Images</Filter>
    17061700    </None>
Note: See TracChangeset for help on using the changeset viewer.