Changeset 157631 in webkit

Timestamp:

Oct 18, 2013 4:26:29 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
​https://bugs.webkit.org/show_bug.cgi?id=122970

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-10-18
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Removed an invalid signal to set objects to an unknown state
layout-complete. This signal was originally generated to notify DRT
and WKTR in case of page load complete.
It was replaced by ATK:AtkDocument:load-complete, which is already sent
by AXObjectCache::frameLoadingEventPlatformNotification().

There is no new test since the changes are covered by existing ones
(e.g. accessibility/loading-iframe-sends-notification.html).

• accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification): Removed an invalid
signal to set objects to an unknown state layout-complete.

Tools:

Removed an invalid signal to set an object state to layout-complete
that does not exist. It was replaced by ATK:AtkDocument:load-complete.

• DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:

(axObjectEventListener): Replaced layout-complete with load-complete.
(connectAccessibilityCallbacks): Connect callback to new listener for
ATK:AtkDocument:load-complete.
(disconnectAccessibilityCallbacks): Disconnect callback to new listener
for ATK:AtkDocument:load-complete.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

(axObjectEventListener): Replaced layout-complete with load-complete.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connect callback to new listener for ATK:AtkDocument:load-complete.
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Disconnect callback to new listener for ATK:AtkDocument:load-complete.

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp (modified) (5 diffs)
• Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp (modified) (5 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
+
+        [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
+        https://bugs.webkit.org/show_bug.cgi?id=122970
+
+        Reviewed by Mario Sanchez Prada.
+
+        Removed an invalid signal to set objects to an unknown state
+        layout-complete. This signal was originally generated to notify DRT
+        and WKTR in case of page load complete.
+        It was replaced by ATK:AtkDocument:load-complete, which is already sent
+        by AXObjectCache::frameLoadingEventPlatformNotification().
+
+        There is no new test since the changes are covered by existing ones
+        (e.g. accessibility/loading-iframe-sends-notification.html).
+
+        * accessibility/atk/AXObjectCacheAtk.cpp:
+        (WebCore::AXObjectCache::postPlatformNotification): Removed an invalid
+        signal to set objects to an unknown state layout-complete.
+
 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp

@@ -165 +165 @@
 
         g_signal_emit_by_name(ATK_OBJECT(axObject), "property-change::accessible-value", &propertyValues, NULL);
-    } else if (notification == AXLayoutComplete)
-        g_signal_emit_by_name(axObject, "state-change", "layout-complete", true);
-    else if (notification == AXInvalidStatusChanged)
+    } else if (notification == AXInvalidStatusChanged)
         g_signal_emit_by_name(axObject, "state-change", "invalid-entry", coreObject->invalidStatus() != "false");
 }

trunk/Tools/ChangeLog

@@ +1 @@
+2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
+
+        [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
+        https://bugs.webkit.org/show_bug.cgi?id=122970
+
+        Reviewed by Mario Sanchez Prada.
+
+        Removed an invalid signal to set an object state to layout-complete
+        that does not exist. It was replaced by ATK:AtkDocument:load-complete.
+
+        * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
+        (axObjectEventListener): Replaced layout-complete with load-complete.
+        (connectAccessibilityCallbacks): Connect callback to new listener for
+        ATK:AtkDocument:load-complete.
+        (disconnectAccessibilityCallbacks): Disconnect callback to new listener
+        for ATK:AtkDocument:load-complete.
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
+        (axObjectEventListener): Replaced layout-complete with load-complete.
+        (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
+        Connect callback to new listener for ATK:AtkDocument:load-complete.
+        (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
+        Disconnect callback to new listener for ATK:AtkDocument:load-complete.
+
 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp

@@ -57 +57 @@
 static guint propertyChangedListenerId = 0;
 static guint visibleDataChangedListenerId = 0;
+static guint loadCompleteListenerId = 0;
 static NotificationHandlersMap notificationHandlers;
 static AccessibilityNotificationHandler* globalNotificationHandler = 0;
@@ -107 +108 @@
         else if (!g_strcmp0(g_value_get_string(&paramValues[1]), "invalid-entry"))
             notificationName = "AXInvalidStatusChanged";
-        else if (!g_strcmp0(g_value_get_string(&paramValues[1]), "layout-complete"))
-            notificationName = "AXLayoutComplete";
     } else if (!g_strcmp0(signalQuery.signal_name, "focus-event")) {
         signalName.set(g_strdup("focus-event"));
@@ -121 +120 @@
         if (!g_strcmp0(g_quark_to_string(signalHint->detail), "accessible-value"))
             notificationName = "AXValueChanged";
-    } else
+    } else if (!g_strcmp0(signalQuery.signal_name, "load-complete"))
+        notificationName = "AXLoadComplete";
+    else
         signalName.set(g_strdup(signalQuery.signal_name));
 
@@ -179 +180 @@
     propertyChangedListenerId = atk_add_global_event_listener(axObjectEventListener, "ATK:AtkObject:property-change");
     visibleDataChangedListenerId = atk_add_global_event_listener(axObjectEventListener, "ATK:AtkObject:visible-data-changed");
+    loadCompleteListenerId = atk_add_global_event_listener(axObjectEventListener, "ATK:AtkDocument:load-complete");
 
     // Ensure the Atk interface types are registered, otherwise
@@ -218 +220 @@
         atk_remove_global_event_listener(visibleDataChangedListenerId);
         visibleDataChangedListenerId = 0;
+    }
+    if (loadCompleteListenerId) {
+        atk_remove_global_event_listener(loadCompleteListenerId);
+        loadCompleteListenerId = 0;
     }
 

trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp

@@ -44 +44 @@
 unsigned propertyChangedListenerId = 0;
 unsigned visibleDataChangedListenerId = 0;
+unsigned loadCompleteListenerId = 0;
 NotificationHandlersMap notificationHandlers;
 AccessibilityNotificationHandler* globalNotificationHandler = 0;
@@ -94 +95 @@
         else if (!g_strcmp0(g_value_get_string(&paramValues[1]), "invalid-entry"))
             notificationName = "AXInvalidStatusChanged";
-        else if (!g_strcmp0(g_value_get_string(&paramValues[1]), "layout-complete"))
-            notificationName = "AXLayoutComplete";
     } else if (!g_strcmp0(signalQuery.signal_name, "focus-event")) {
         signalName.set(g_strdup("focus-event"));
@@ -108 +107 @@
         if (!g_strcmp0(g_quark_to_string(signalHint->detail), "accessible-value"))
             notificationName = "AXValueChanged";
-    } else
+    } else if (!g_strcmp0(signalQuery.signal_name, "load-complete"))
+        notificationName = "AXLoadComplete";
+    else
         signalName.set(g_strdup(signalQuery.signal_name));
 
@@ -241 +242 @@
     propertyChangedListenerId = atk_add_global_event_listener(axObjectEventListener, "ATK:AtkObject:property-change");
     visibleDataChangedListenerId = atk_add_global_event_listener(axObjectEventListener, "ATK:AtkObject:visible-data-changed");
+    loadCompleteListenerId = atk_add_global_event_listener(axObjectEventListener, "ATK:AtkDocument:load-complete");
 }
 
@@ -274 +276 @@
         visibleDataChangedListenerId = 0;
     }
-
+    if (loadCompleteListenerId) {
+        atk_remove_global_event_listener(loadCompleteListenerId);
+        loadCompleteListenerId = 0;
+    }
     return true;
 }