Changeset 158094 in webkit

Timestamp:

Oct 26, 2013 5:48:30 PM (10 years ago)

Author:

rniwa@webkit.org

Message:

New flakiness dashboard should support substring matching
​https://bugs.webkit.org/show_bug.cgi?id=123393

Reviewed by Alexey Proskuryakov.

Addressed the use cases by

1. Always showing the candidate even when there is exactly one test matching the current value.
2. Adding all tests that match the current value upon the user pressing enter key.

• public/index.html:

(fetchManifest): Add all tests that match the current value. Confirm whether the user really
want to add all the tests when there are more than 15 tests to add.

• public/js/autocompleter.js:

(Autocompleter.prototype.filterCandidates): Extracted from _updateCandidates.
(Autocompleter.prototype._updateCandidates): Show the candidate window even when there is
exactly one test that matches the criteria so that the user can select this test.

Location:

trunk/Websites/test-results

Files:

• ChangeLog (modified) (1 diff)
• public/index.html (modified) (1 diff)
• public/js/autocompleter.js (modified) (2 diffs)

trunk/Websites/test-results/ChangeLog

@@ +1 @@
+2013-10-26  Ryosuke Niwa  <rniwa@webkit.org>
+
+        New flakiness dashboard should support substring matching
+        https://bugs.webkit.org/show_bug.cgi?id=123393
+
+        Reviewed by Alexey Proskuryakov.
+
+        Addressed the use cases by
+        1. Always showing the candidate even when there is exactly one test matching the current value.
+        2. Adding all tests that match the current value upon the user pressing enter key.
+
+        * public/index.html:
+        (fetchManifest): Add all tests that match the current value. Confirm whether the user really
+        want to add all the tests when there are more than 15 tests to add.
+        * public/js/autocompleter.js:
+        (Autocompleter.prototype.filterCandidates): Extracted from _updateCandidates.
+        (Autocompleter.prototype._updateCandidates): Show the candidate window even when there is
+        exactly one test that matches the criteria so that the user can select this test.
+
 2013-10-26  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/test-results/public/index.html

@@ -519 +519 @@
     input.autocompleter = new Autocompleter(input, testNames);
 
+    input.form.onsubmit = function (event) {
+        addTests(input.value);
+        event.preventDefault();
+        return false;
+    }
+
+    function addTests(filter) {
+        var candidates = input.autocompleter.filterCandidates(filter);
+        if (candidates.length > 15) {
+            if (!confirm('Are you sure you want to add ' + candidates.length + ' tests that match this substring?'))
+                return;
+        }
+        for (var i = 0; i < candidates.length; i++)
+            TestResultsView.fetchTest(candidates[i]);
+        TestResultsView.updateLocationHash();
+    }
+
     var builderListView = document.getElementById('builderListView');
     TestResultsView._sortObjectsByName(response['builders']).forEach(function (builder) {

trunk/Websites/test-results/public/js/autocompleter.js

@@ -11 +11 @@
     inputElement.addEventListener('keyup', this.update.bind(this));
     inputElement.addEventListener('keydown', this.navigate.bind(this));
+}
+
+Autocompleter.prototype.filterCandidates = function (filter) {
+    return this._list.filter(function (testName) { return testName.indexOf(filter) >= 0; });
 }
 
@@ -29 +33 @@
         return false;
 
-    var candidates = this._list.filter(function (testName) { return testName.indexOf(filter) >= 0; });
-    if (candidates.length > 50 || candidates.length == 1)
+    var candidates = this.filterCandidates(filter);
+    if (candidates.length > 50)
         candidates = [];
     this._candidates = candidates;