Changeset 158102 in webkit

Timestamp:

Oct 28, 2013 12:29:21 AM (10 years ago)

Author:

zandobersek@gmail.com

Message:

Re-enable simple line layout for GTK
​https://bugs.webkit.org/show_bug.cgi?id=123388

Reviewed by Andreas Kling.

Source/WebCore:

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor): 8-bit TextRun support is now enabled for the GTK port, so the port
can use the simple line layout.

Source/WTF:

• wtf/FeatureDefines.h: Enable the 8-bit TextRun support for the GTK port.

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/FeatureDefines.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/SimpleLineLayout.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-10-28  Zan Dobersek  <zdobersek@igalia.com>
+
+        Re-enable simple line layout for GTK
+        https://bugs.webkit.org/show_bug.cgi?id=123388
+
+        Reviewed by Andreas Kling.
+
+        * wtf/FeatureDefines.h: Enable the 8-bit TextRun support for the GTK port.
+
 2013-10-25  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WTF/wtf/FeatureDefines.h

@@ -300 +300 @@
 #endif
 
+#if !defined(ENABLE_8BIT_TEXTRUN)
+#define ENABLE_8BIT_TEXTRUN 1
+#endif
+
 #endif /* PLATFORM(GTK) */
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-10-28  Zan Dobersek  <zdobersek@igalia.com>
+
+        Re-enable simple line layout for GTK
+        https://bugs.webkit.org/show_bug.cgi?id=123388
+
+        Reviewed by Andreas Kling.
+
+        * rendering/SimpleLineLayout.cpp:
+        (WebCore::SimpleLineLayout::canUseFor): 8-bit TextRun support is now enabled for the GTK port, so the port
+        can use the simple line layout.
+
 2013-10-27  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/rendering/SimpleLineLayout.cpp

@@ -55 +55 @@
 bool canUseFor(const RenderBlockFlow& flow)
 {
-#if !PLATFORM(MAC)
+#if !PLATFORM(MAC) && !PLATFORM(GTK)
     // FIXME: Non-mac platforms are hitting ASSERT(run.charactersLength() >= run.length())
     // https://bugs.webkit.org/show_bug.cgi?id=123338