Changeset 158242 in webkit


Ignore:
Timestamp:
Oct 29, 2013 5:58:22 PM (10 years ago)
Author:
Brent Fulgham
Message:

REGRESSION(r158198): editing/execCommand/insert-list-xml.xhtml fails
https://bugs.webkit.org/show_bug.cgi?id=123460

Reviewed by Ryosuke Niwa.

The original version of this test used a MathML document root,
and attempted to add HTML content to prove that a bad cast would
not be encountered when manipulating the MathML document via
JavaScript.

r158198 broke the test, because it enforced the requirements that
MathML nodes not generate renderers for non-MathML children.

This patch revises the test to use an SVG document, which does
permit child HTML nodes.

  • TestExpectations: Remove temporary exclusion landed in r158216.
  • editing/execCommand/insert-list-xml-expected.txt:
  • editing/execCommand/insert-list-xml.xhtml:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r158241 r158242  
     12013-10-29  Brent Fulgham  <bfulgham@apple.com>
     2
     3        REGRESSION(r158198): editing/execCommand/insert-list-xml.xhtml fails
     4        https://bugs.webkit.org/show_bug.cgi?id=123460
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        The original version of this test used a MathML document root,
     9        and attempted to add HTML content to prove that a bad cast would
     10        not be encountered when manipulating the MathML document via
     11        JavaScript.
     12
     13        r158198 broke the test, because it enforced the requirements that
     14        MathML nodes not generate renderers for non-MathML children.
     15
     16        This patch revises the test to use an SVG document, which does
     17        permit child HTML nodes.
     18
     19        * TestExpectations: Remove temporary exclusion landed in
     20          r158216.
     21        * editing/execCommand/insert-list-xml-expected.txt:
     22        * editing/execCommand/insert-list-xml.xhtml:
     23
    1242013-10-29  Ryosuke Niwa  <rniwa@webkit.org>
    225
  • trunk/LayoutTests/TestExpectations

    r158216 r158242  
    7676webkit.org/b/122679 security/crypto-subtle-gc-2.html [ Skip ]
    7777webkit.org/b/122679 security/crypto-subtle-gc-3.html [ Skip ]
    78 
    79 webkit.org/b/123460 editing/execCommand/insert-list-xml.xhtml [ Failure ]
  • trunk/LayoutTests/editing/execCommand/insert-list-xml.xhtml

    r120173 r158242  
    1 <mat:diff xmlns:mat="http://www.w3.org/1998/Math/MathML">
    2   <html xmlns="http://www.w3.org/1999/xhtml"> 
    3     <head>
     1<?xml version="1.0" standalone="yes"?>
     2<svg xmlns = "http://www.w3.org/2000/svg">
     3  <foreignObject x="10" y="10" width="800" height="150">
     4    <body xmlns="http://www.w3.org/1999/xhtml" onload="start();">
    45      <script type="text/javascript">
    56        if (window.testRunner)
     
    2324        }
    2425      </script>
    25     </head>
    26     <body onload="start();">
    2726      <div contenteditable="true" id="insertlisthere">.</div>
    28     <ul id="console"></ul>
     27      <ul id="console"></ul>
    2928    </body>
    30   </html>
    31 </mat:diff>
     29  </foreignObject>
     30</svg>
Note: See TracChangeset for help on using the changeset viewer.