Changeset 158352 in webkit


Ignore:
Timestamp:
Oct 31, 2013 1:38:28 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

[EFL] accessibility/textbox-role-reports-selection.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112017

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-31
Reviewed by Mario Sanchez Prada.

Source/WebCore:

getSelectionOffsetsForObject() now returns proper start/end offsets for
selections "touching" the object's front border.

No new tests, covered by existing ones.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject):

LayoutTests:

Removed failure expectations.

  • platform/efl-wk1/TestExpectations: The test is no longer failing.
  • platform/efl-wk2/TestExpectations: The test is no longer failing.
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r158344 r158352  
     12013-10-31  Robert Plociennik  <r.plociennik@samsung.com>
     2
     3        [EFL] accessibility/textbox-role-reports-selection.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=112017
     5
     6        Reviewed by Mario Sanchez Prada.
     7
     8        Removed failure expectations.
     9
     10        * platform/efl-wk1/TestExpectations: The test is no longer failing.
     11        * platform/efl-wk2/TestExpectations: The test is no longer failing.
     12
    1132013-10-30  Ryosuke Niwa  <rniwa@webkit.org>
    214
  • trunk/LayoutTests/platform/efl-wk1/TestExpectations

    r158273 r158352  
    165165webkit.org/b/112014 accessibility/textarea-insertion-point-line-number.html [ Failure ]
    166166webkit.org/b/112015 accessibility/textarea-line-for-index.html [ Failure ]
    167 webkit.org/b/112017 accessibility/textbox-role-reports-selection.html [ Failure ]
    168167webkit.org/b/112018 accessibility/th-as-title-ui.html [ Failure ]
    169168webkit.org/b/112019 accessibility/title-ui-element-correctness.html [ Failure ]
  • trunk/LayoutTests/platform/efl-wk2/TestExpectations

    r158273 r158352  
    165165webkit.org/b/112014 accessibility/textarea-insertion-point-line-number.html [ Failure ]
    166166webkit.org/b/112015 accessibility/textarea-line-for-index.html [ Failure ]
    167 webkit.org/b/112017 accessibility/textbox-role-reports-selection.html [ Failure ]
    168167webkit.org/b/112018 accessibility/th-as-title-ui.html [ Failure ]
    169168webkit.org/b/112019 accessibility/title-ui-element-correctness.html [ Failure ]
  • trunk/Source/WebCore/ChangeLog

    r158351 r158352  
     12013-10-31  Robert Plociennik  <r.plociennik@samsung.com>
     2
     3        [EFL] accessibility/textbox-role-reports-selection.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=112017
     5
     6        Reviewed by Mario Sanchez Prada.
     7
     8        getSelectionOffsetsForObject() now returns proper start/end offsets for
     9        selections "touching" the object's front border.
     10
     11        No new tests, covered by existing ones.
     12
     13        * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
     14        (getSelectionOffsetsForObject):
     15
    1162013-10-31  Ryuan Choi  <ryuan.choi@samsung.com>
    217
  • trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp

    r158163 r158352  
    519519    // Early return with proper values if the selection falls entirely out of the object.
    520520    if (!selectionBelongsToObject(coreObject, selection)) {
    521         startOffset = comparePositions(selection.start(), firstValidPosition) < 0 ? 0 : accessibilityObjectLength(coreObject);
     521        startOffset = comparePositions(selection.start(), firstValidPosition) <= 0 ? 0 : accessibilityObjectLength(coreObject);
    522522        endOffset = startOffset;
    523523        return;
Note: See TracChangeset for help on using the changeset viewer.