Changeset 158734 in webkit
- Timestamp:
- Nov 6, 2013 1:32:26 AM (10 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r158731 r158734 1 2013-11-06 Piotr Grad <p.grad@samsung.com> 2 3 Test for seek not working properly with negative playback rate. 4 https://bugs.webkit.org/show_bug.cgi?id=123791 5 6 Seek method should work properly with negative playback rate. 7 8 Reviewed by Philippe Normand. 9 10 * media/video-seek-with-negative-playback.html: Added. 11 * media/video-seek-with-negative-playback-expected.txt: Added. 12 1 13 2013-11-06 Ryosuke Niwa <rniwa@webkit.org> 2 14 -
trunk/Source/WebCore/ChangeLog
r158733 r158734 1 2013-11-06 Piotr Grad <p.grad@samsung.com> 2 3 Seek for video doesn't work when playback rate is negative 4 https://bugs.webkit.org/show_bug.cgi?id=123791 5 6 In MediaPlayerPrivateGStreamer::seek negative playback rate was not taken to account. 7 8 Reviewed by Philippe Normand. 9 10 Test: media/video-seek-with-negative-playback.html 11 12 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: 13 (WebCore::MediaPlayerPrivateGStreamer::seek): 14 1 15 2013-11-06 Andreas Kling <akling@apple.com> 2 16 -
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
r158436 r158734 614 614 } 615 615 } else { 616 gint64 startTime, endTime; 617 if (m_player->rate() > 0) { 618 startTime = clockTime; 619 endTime = GST_CLOCK_TIME_NONE; 620 } else { 621 startTime = 0; 622 endTime = clockTime; 623 } 624 616 625 // We can seek now. 617 626 if (!gst_element_seek(m_playBin.get(), m_player->rate(), GST_FORMAT_TIME, static_cast<GstSeekFlags>(GST_SEEK_FLAG_FLUSH | GST_SEEK_FLAG_ACCURATE), 618 GST_SEEK_TYPE_SET, clockTime, GST_SEEK_TYPE_NONE, GST_CLOCK_TIME_NONE)) {627 GST_SEEK_TYPE_SET, startTime, GST_SEEK_TYPE_SET, endTime)) { 619 628 LOG_MEDIA_MESSAGE("[Seek] seeking to %f failed", time); 620 629 return;
Note: See TracChangeset
for help on using the changeset viewer.