Changeset 158734 in webkit


Ignore:
Timestamp:
Nov 6, 2013 1:32:26 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

Source/WebCore: Seek for video doesn't work when playback rate is negative
https://bugs.webkit.org/show_bug.cgi?id=123791

In MediaPlayerPrivateGStreamer::seek negative playback rate was not taken to account.

Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-06
Reviewed by Philippe Normand.

Test: media/video-seek-with-negative-playback.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::seek):

LayoutTests: Test for seek not working properly with negative playback rate.
https://bugs.webkit.org/show_bug.cgi?id=123791

Seek method should work properly with negative playback rate.

Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-06
Reviewed by Philippe Normand.

  • media/video-seek-with-negative-playback.html: Added.
  • media/video-seek-with-negative-playback-expected.txt: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r158731 r158734  
     12013-11-06  Piotr Grad  <p.grad@samsung.com>
     2
     3        Test for seek not working properly with negative playback rate.
     4        https://bugs.webkit.org/show_bug.cgi?id=123791
     5
     6        Seek method should work properly with negative playback rate.
     7
     8        Reviewed by Philippe Normand.
     9
     10        * media/video-seek-with-negative-playback.html: Added.
     11        * media/video-seek-with-negative-playback-expected.txt: Added.
     12
    1132013-11-06  Ryosuke Niwa  <rniwa@webkit.org>
    214
  • trunk/Source/WebCore/ChangeLog

    r158733 r158734  
     12013-11-06  Piotr Grad  <p.grad@samsung.com>
     2
     3        Seek for video doesn't work when playback rate is negative
     4        https://bugs.webkit.org/show_bug.cgi?id=123791
     5
     6        In MediaPlayerPrivateGStreamer::seek negative playback rate was not taken to account.
     7
     8        Reviewed by Philippe Normand.
     9
     10        Test: media/video-seek-with-negative-playback.html
     11
     12        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
     13        (WebCore::MediaPlayerPrivateGStreamer::seek):
     14
    1152013-11-06  Andreas Kling  <akling@apple.com>
    216
  • trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

    r158436 r158734  
    614614        }
    615615    } else {
     616        gint64 startTime, endTime;
     617        if (m_player->rate() > 0) {
     618            startTime = clockTime;
     619            endTime = GST_CLOCK_TIME_NONE;
     620        } else {
     621            startTime = 0;
     622            endTime = clockTime;
     623        }
     624
    616625        // We can seek now.
    617626        if (!gst_element_seek(m_playBin.get(), m_player->rate(), GST_FORMAT_TIME, static_cast<GstSeekFlags>(GST_SEEK_FLAG_FLUSH | GST_SEEK_FLAG_ACCURATE),
    618             GST_SEEK_TYPE_SET, clockTime, GST_SEEK_TYPE_NONE, GST_CLOCK_TIME_NONE)) {
     627            GST_SEEK_TYPE_SET, startTime, GST_SEEK_TYPE_SET, endTime)) {
    619628            LOG_MEDIA_MESSAGE("[Seek] seeking to %f failed", time);
    620629            return;
Note: See TracChangeset for help on using the changeset viewer.